Merge lp:~openerp-dev/openobject-addons/6.0-opw-6344-rch into lp:openobject-addons/6.0
Proposed by
Riken Bhorania (OpenERP)
Status: | Needs review |
---|---|
Proposed branch: | lp:~openerp-dev/openobject-addons/6.0-opw-6344-rch |
Merge into: | lp:openobject-addons/6.0 |
Diff against target: |
13 lines (+0/-3) 1 file modified
account/invoice.py (+0/-3) |
To merge this branch: | bzr merge lp:~openerp-dev/openobject-addons/6.0-opw-6344-rch |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
qdp (OpenERP) | Disapprove | ||
Jay Vora (Serpent Consulting Services) | Pending | ||
Review via email: mp+66606@code.launchpad.net |
Description of the change
Restrict to create unwanted journal entries in the case of partial deductible tax scenario.
To post a comment you must log in.
Unmerged revisions
- 4686. By Riken Bhorania (OpenERP)
-
[FIX]: account: Restrict to create unwanted journal entries in the case of partial tax deductible senario.
you need to make sure that the configuration of the taxes is correct.
Here the line with debit = credit = 0 is created because there is a value in tax_amount and tax_code_id fields. So this line is important. Either that vat information shouldn't be there (because it's already on another line, for example, and thus it means that the configuration is wrong) or it has to be there (and thus we can't just modify the code to remove those lines)
so i guess that the MP proposal is wrong