Odoo Addons (MOVED TO GITHUB)

Code review comment for lp:~openerp-dev/openobject-addons/6.0-opw-57608-ira

  1. 6.0-opw-57608-ira
  2. Merge into 6.0
Revision history for this message
Xavier ALT (dex-phx) wrote :

Hello Ila,

Two things that needd to be fixed:

- You're reading the "company_id" in an account.analytic.account, but the "company_id" field is not required on that object, so make sure there is one, otherwise the final "company[0]" will crash.

- You should move that code into "hr_timesheet" module, because here we're inheriting from "hr.analytic.timesheet" object, and your code don't depend on new fields introduce by "hr_timesheet_sheet" module.

Regards,
Xavier

review: Needs Fixing
Reply

« Back to merge proposal