Code review comment for lp:~openerp-dev/openobject-addons/6.0-opw-50587-ira

Revision history for this message
Serpent Consulting Services (serpent-consulting-services) wrote :

Hello Ila Rana,

I see there are still the chances for optimization of this code.

The use of statement 'product_obj.browse(cr, uid, data['product_id'], context=context)' is many times rather than once.

Though it doesn't affect the fix, but its always better to prevent future optimization requests.

Moreover, 'res_obj.browse(cr, uid, uid, context=context)' is also ill-treated.

Hope this would surely help.

Thanks,
Serpent Consulting Services.

« Back to merge proposal