Code review comment for lp:~openerp-dev/openobject-addons/5.0-opw-7285-pso

Revision history for this message
qdp (OpenERP) (qdp) wrote :

Seems correct, but i didn't run it or tried with a real instance. I guess it's good to be merged if you did so.

as discussed, it should be a good idea to also include:
- a check that raises an error if the statement's journal and its default accounts don't share the same configuration for secondary currency.
- a domain in the account.move.line m2m of bank statements when going by "periodical processing \ bank reconciliation \ .." in order to make sure that people encode there only accounting entries with a correct secondary currency set.

Thanks,
Quentin

review: Approve

« Back to merge proposal