Code review comment for lp:~openerp-dev/openobject-addons/5.0-opw-17363-skh

Revision history for this message
Jay Vora (Serpent Consulting Services) (jayvora) wrote :

I would like to suggest one thing here.

You could have optimized the code by removing one for loop of picking_id:
I meant, self.read and sale.picking_ids would be always same!

Similar logic should have been applied for invoice_ids as well.

Additionally:
1. To reach to procurements, you may also reach by sale order lines!
2. wf_service = netsvc.LocalService("workflow") has been used twice. You could have opted to optimize that as well.
3. Based on the suggestion of reducing loops, you can improve v6 as well.

Thanks.

« Back to merge proposal