Merge lp:~openerp-dev/openerp-web/trunk-kanban-document-bth into lp:openerp-web

Proposed by Bhumi Thakkar (Open ERP)
Status: Work in progress
Proposed branch: lp:~openerp-dev/openerp-web/trunk-kanban-document-bth
Merge into: lp:openerp-web
Diff against target: 119 lines (+26/-20)
3 files modified
addons/web/static/src/js/view_form.js (+5/-3)
addons/web/static/src/xml/base.xml (+5/-15)
addons/web_kanban/static/src/js/kanban.js (+16/-2)
To merge this branch: bzr merge lp:~openerp-dev/openerp-web/trunk-kanban-document-bth
Reviewer Review Type Date Requested Status
OpenERP R&D Web Team Pending
Review via email: mp+156804@code.launchpad.net

Description of the change

Hello,

        Fixed 2 issues related document or attachment.
=> There is no any file in record still download link is displayed and also if clicked on download link download the file. So remove the link if there is no file.

=> There is no any file and if click on saveas then save the file. which is fixed by if there is any file then saveas will work else not.

Thanks.

To post a comment you must log in.
3712. By Bhumi Thakkar (Open ERP)

[MERGE] Merge lp:openerp-web.

3713. By Bhumi Thakkar (Open ERP)

[IMP] Add function to download files from kanban.

3714. By Bhumi Thakkar (Open ERP)

[MERGE] Merge lp:openerp-web.

Revision history for this message
Bhumi Thakkar (Open ERP) (bth-openerp) wrote :

Hello,

    Add function to download file from kanban view for generic.

Thanks.

3715. By Bhumi Thakkar (Open ERP)

[MERGE] Merge lp:openerp-web.

3716. By Bhumi Thakkar (Open ERP)

[MERGE]Merge lp:openerp-web.

3717. By Bhumi Thakkar (Open ERP)

[MERGE]Merge lp:openerp-web.

3718. By Bhumi Thakkar (Open ERP)

[MERGE] Merge lp:openerp-web.

3719. By Bhumi Thakkar (Open ERP)

[MERGE]Merge lp:openerp-web.

3720. By Bhumi Thakkar (Open ERP)

[MERGE]Merge lp:openerp-web.

3721. By Bhumi Thakkar (Open ERP)

[IMP]Add function of kanban url if there is no http:// in url value then return with http://.

3722. By Bhumi Thakkar (Open ERP)

[MERGE]Merge lp:openerp-web.

3723. By Bhumi Thakkar (Open ERP)

[MERGE]Merge lp:openerp-web.

3724. By Bhumi Thakkar (Open ERP)

[MERGE]Merge lp:openerp-web.

3725. By Bhumi Thakkar (Open ERP)

[MERGE]Merge lp:openerp-web.

3726. By Bhumi Thakkar (Open ERP)

[IMP]Removed button and add links into file widget.

3727. By Bhumi Thakkar (Open ERP)

[IMP]Improved code to set links besides input type='file'.

3728. By Bhumi Thakkar (Open ERP)

[MERGE]Merge lp:openerp-web.

3729. By Bhumi Thakkar (Open ERP)

[MERGE]Merge lp:openerp-web.

3730. By Bhumi Thakkar (Open ERP)

[MERGE]Merge lp:openerp-web.

3731. By Bhumi Thakkar (Open ERP)

[MERGE]Merge lp:openerp-web.

3732. By Bhumi Thakkar (Open ERP)

[MERGE]Merge trunk.

3733. By Bhumi Thakkar (Open ERP)

[MERGE]Merge trunk.

3734. By Bhumi Thakkar (Open ERP)

[IMP]Formatting.

3735. By Bhumi Thakkar (Open ERP)

[MERGE]Merge trunk.

3736. By Bhumi Thakkar (Open ERP)

[IMP]Improved css class name and code.

3737. By Bhumi Thakkar (Open ERP)

[IMP]Create method to call server side method to return extension.

3738. By Bhumi Thakkar (Open ERP)

[MERGE]Merge trunk.

3739. By Bhumi Thakkar (Open ERP)

[MERGE]Merge trunk.

3740. By Sunil Sharma(OpenERP)

[IMP]:kanban filetype:

3741. By Bhumi Thakkar (Open ERP)

[MERGE]Merge trunk.

3742. By Bhumi Thakkar (Open ERP)

[MERGE]Merge trunk.

3743. By Bhumi Thakkar (Open ERP)

[MERGE]Merge trunk.

3744. By Darshan Kalola(OpenERP)

[MERGE]sync with trunk.

3745. By Sunil Sharma(OpenERP)

[MRG]:Merge lp:openerp-web

3746. By Chirag Dodiya(OpenERP)

[MRG]Merge with trunk

Unmerged revisions

3746. By Chirag Dodiya(OpenERP)

[MRG]Merge with trunk

3745. By Sunil Sharma(OpenERP)

[MRG]:Merge lp:openerp-web

3744. By Darshan Kalola(OpenERP)

[MERGE]sync with trunk.

3743. By Bhumi Thakkar (Open ERP)

[MERGE]Merge trunk.

3742. By Bhumi Thakkar (Open ERP)

[MERGE]Merge trunk.

3741. By Bhumi Thakkar (Open ERP)

[MERGE]Merge trunk.

3740. By Sunil Sharma(OpenERP)

[IMP]:kanban filetype:

3739. By Bhumi Thakkar (Open ERP)

[MERGE]Merge trunk.

3738. By Bhumi Thakkar (Open ERP)

[MERGE]Merge trunk.

3737. By Bhumi Thakkar (Open ERP)

[IMP]Create method to call server side method to return extension.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'addons/web/static/src/js/view_form.js'
--- addons/web/static/src/js/view_form.js 2014-02-20 14:13:02 +0000
+++ addons/web/static/src/js/view_form.js 2014-03-04 12:37:08 +0000
@@ -5198,7 +5198,7 @@
5198 },5198 },
5199 initialize_content: function() {5199 initialize_content: function() {
5200 this.$el.find('input.oe_form_binary_file').change(this.on_file_change);5200 this.$el.find('input.oe_form_binary_file').change(this.on_file_change);
5201 this.$el.find('button.oe_form_binary_file_save').click(this.on_save_as);5201 this.$el.find('.oe_form_binary_file_save').click(this.on_save_as);
5202 this.$el.find('.oe_form_binary_file_clear').click(this.on_clear);5202 this.$el.find('.oe_form_binary_file_clear').click(this.on_clear);
5203 },5203 },
5204 on_file_change: function(e) {5204 on_file_change: function(e) {
@@ -5246,7 +5246,7 @@
5246 if (!value) {5246 if (!value) {
5247 this.do_warn(_t("Save As..."), _t("The field is empty, there's nothing to save !"));5247 this.do_warn(_t("Save As..."), _t("The field is empty, there's nothing to save !"));
5248 ev.stopPropagation();5248 ev.stopPropagation();
5249 } else {5249 } else if (this.view.datarecord[this.node.attrs.filename]) {
5250 instance.web.blockUI();5250 instance.web.blockUI();
5251 var c = instance.webclient.crashmanager;5251 var c = instance.webclient.crashmanager;
5252 this.session.get_file({5252 this.session.get_file({
@@ -5309,7 +5309,9 @@
5309 } else {5309 } else {
5310 this.$el.find('a').toggle(!!this.get('value'));5310 this.$el.find('a').toggle(!!this.get('value'));
5311 if (this.get('value')) {5311 if (this.get('value')) {
5312 show_value = _t("Download");5312 var show_value = '';
5313 if (this.view.datarecord[this.node.attrs.filename])
5314 show_value = _t("Download")
5313 if (this.view)5315 if (this.view)
5314 show_value += " " + (this.view.datarecord[this.node.attrs.filename] || '');5316 show_value += " " + (this.view.datarecord[this.node.attrs.filename] || '');
5315 this.$el.find('a').text(show_value);5317 this.$el.find('a').text(show_value);
53165318
=== modified file 'addons/web/static/src/xml/base.xml'
--- addons/web/static/src/xml/base.xml 2014-02-12 14:19:59 +0000
+++ addons/web/static/src/xml/base.xml 2014-03-04 12:37:08 +0000
@@ -1244,34 +1244,24 @@
1244 t-att-tabindex="widget.node.attrs.tabindex"1244 t-att-tabindex="widget.node.attrs.tabindex"
1245 t-att-autofocus="widget.node.attrs.autofocus"1245 t-att-autofocus="widget.node.attrs.autofocus"
1246 class="field_binary"1246 class="field_binary"
1247 style="position:absolute;"
1247 />1248 />
1248 </td>1249 </td>
1249 <td class="oe_form_binary" nowrap="true">1250 <td class="oe_form_binary" nowrap="true" style="padding-left:35px;">
1250 <table cellspacing="0" cellpadding="0" border="0">1251 <table cellspacing="0" cellpadding="0" border="0">
1251 <tr>1252 <tr>
1252 <td>1253 <td>
1253 <t t-call="HiddenInputFile">1254 <t t-call="HiddenInputFile">
1254 <t t-set="fileupload_id" t-value="widget.fileupload_id"/>1255 <t t-set="fileupload_id" t-value="widget.fileupload_id"/>
1255 <t t-set="fileupload_style" t-translation="off">width: 83px;</t>1256 <t t-set="fileupload_style" t-translation="off">width: 83px;</t>
1256 <button class="oe_button oe_field_button" type="button">1257 <a class="oe_select_file">Select</a>
1257 <img t-att-src='_s + "/web/static/src/img/icons/STOCK_DIRECTORY.png"'/>
1258 <span>Select</span>
1259 </button>
1260 </t>1258 </t>
1261 </td>1259 </td>
1262 <td>1260 <td>
1263 <a class="oe_form_binary_file_save_data">1261 <a class="oe_link oe_form_binary_file_save">Save As</a>
1264 <button class="oe_button oe_form_binary_file_save" type="button" title="Save As">
1265 <img t-att-src='_s + "/web/static/src/img/icons/gtk-save.png"'/>
1266 <span>Save As</span>
1267 </button>
1268 </a>
1269 </td>1262 </td>
1270 <td>1263 <td>
1271 <button class="oe_button oe_form_binary_file_clear" type="button" title="Clear">1264 <a class="oe_link oe_form_binary_file_clear">Clear</a>
1272 <img t-att-src='_s + "/web/static/src/img/icons/STOCK_MISSING_IMAGE.png"'/>
1273 <span>Clear</span>
1274 </button>
1275 </td>1265 </td>
1276 </tr>1266 </tr>
1277 </table>1267 </table>
12781268
=== modified file 'addons/web_kanban/static/src/js/kanban.js'
--- addons/web_kanban/static/src/js/kanban.js 2014-01-31 00:52:02 +0000
+++ addons/web_kanban/static/src/js/kanban.js 2014-03-04 12:37:08 +0000
@@ -1119,6 +1119,9 @@
1119 }1119 }
1120 return url;1120 return url;
1121 },1121 },
1122 kanban_download: function(id) {
1123 return this.session.url('/web/binary/saveas', {model: 'ir.attachment', field: 'datas', filename_field: 'datas_fname', id: id});
1124 },
1122 kanban_text_ellipsis: function(s, size) {1125 kanban_text_ellipsis: function(s, size) {
1123 size = size || 160;1126 size = size || 160;
1124 if (!s) {1127 if (!s) {
@@ -1131,7 +1134,18 @@
1131 },1134 },
1132 kanban_compute_domain: function(domain) {1135 kanban_compute_domain: function(domain) {
1133 return instance.web.form.compute_domain(domain, this.values);1136 return instance.web.form.compute_domain(domain, this.values);
1134 }1137 },
1138 kanban_url: function(value) {
1139 var s = /(\w+):(.+)|^\.{0,2}\//.exec(value);
1140 var url = "";
1141 if (!s) {
1142 url = "http://"+value;
1143 }
1144 return url || value;
1145 },
1146 kanban_filetype: function(url) {
1147 return instance.base.filetype(url);
1148 },
1135});1149});
11361150
1137/**1151/**
@@ -1145,7 +1159,7 @@
1145 */1159 */
1146instance.web_kanban.QuickCreate = instance.web.Widget.extend({1160instance.web_kanban.QuickCreate = instance.web.Widget.extend({
1147 template: 'KanbanView.quick_create',1161 template: 'KanbanView.quick_create',
1148 1162
1149 /**1163 /**
1150 * close_btn: If true, the widget will display a "Close" button able to trigger1164 * close_btn: If true, the widget will display a "Close" button able to trigger
1151 * a "close" event.1165 * a "close" event.