Merge lp:~openerp-dev/openerp-web/trunk-improve-view-aja into lp:openerp-web

Proposed by ajay javiya (OpenERP)
Status: Rejected
Rejected by: Antony Lesuisse (OpenERP)
Proposed branch: lp:~openerp-dev/openerp-web/trunk-improve-view-aja
Merge into: lp:openerp-web
Diff against target: 56 lines (+13/-1)
3 files modified
addons/web/static/src/css/base.css (+4/-1)
addons/web/static/src/css/base.sass (+2/-0)
addons/web/static/src/js/view_form.js (+7/-0)
To merge this branch: bzr merge lp:~openerp-dev/openerp-web/trunk-improve-view-aja
Reviewer Review Type Date Requested Status
OpenERP Core Team Pending
Review via email: mp+179676@code.launchpad.net

Description of the change

Hello ,
FIX : when two group inside one group ,and if first group is invisible then add extra padding on left in second group.
Thank You.

To post a comment you must log in.
3788. By ajay javiya (OpenERP)

[MERGE]: with trunk

3789. By ajay javiya (OpenERP)

[MERGE] : with trunk

3790. By ajay javiya (OpenERP)

[FIX]: Alignment issue when group is apply on group tag

3791. By ajay javiya (OpenERP)

[MERGE]: with trunk

Revision history for this message
Antony Lesuisse (OpenERP) (al-openerp) wrote :

too late, switch to boostrap is happening in parallel

Unmerged revisions

3791. By ajay javiya (OpenERP)

[MERGE]: with trunk

3790. By ajay javiya (OpenERP)

[FIX]: Alignment issue when group is apply on group tag

3789. By ajay javiya (OpenERP)

[MERGE] : with trunk

3788. By ajay javiya (OpenERP)

[MERGE]: with trunk

3787. By ajay javiya (OpenERP)

[IMP]:css and code

3786. By ajay javiya (OpenERP)

[MERGE] : with trunk

3785. By ajay javiya (OpenERP)

[IMP]:view when two group inside one group ,and first group is invisible then add extra padding on left

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'addons/web/static/src/css/base.css'
--- addons/web/static/src/css/base.css 2013-10-18 12:32:53 +0000
+++ addons/web/static/src/css/base.css 2013-11-11 05:45:18 +0000
@@ -1,4 +1,4 @@
1@charset "utf-8";1@charset "UTF-8";
2@font-face {2@font-face {
3 font-family: "mnmliconsRegular";3 font-family: "mnmliconsRegular";
4 src: url("/web/static/src/font/mnmliconsv21-webfont.eot") format("eot");4 src: url("/web/static/src/font/mnmliconsv21-webfont.eot") format("eot");
@@ -2320,6 +2320,9 @@
2320.openerp .oe_form .oe_form_group .oe_form_group_cell.oe_group_right {2320.openerp .oe_form .oe_form_group .oe_form_group_cell.oe_group_right {
2321 padding-left: 20px;2321 padding-left: 20px;
2322}2322}
2323.openerp .oe_form .oe_form_group .oe_form_group_cell.oe_group_left {
2324 padding-left: 0px;
2325}
2323.openerp .oe_form .oe_form_label_help[for], .openerp .oe_form .oe_form_label[for] {2326.openerp .oe_form .oe_form_label_help[for], .openerp .oe_form .oe_form_label[for] {
2324 font-weight: bold;2327 font-weight: bold;
2325 white-space: nowrap;2328 white-space: nowrap;
23262329
=== modified file 'addons/web/static/src/css/base.sass'
--- addons/web/static/src/css/base.sass 2013-10-18 12:32:53 +0000
+++ addons/web/static/src/css/base.sass 2013-11-11 05:45:18 +0000
@@ -1837,6 +1837,8 @@
1837 margin: 9px 0 9px 01837 margin: 9px 0 9px 0
1838 .oe_form_group_cell.oe_group_right1838 .oe_form_group_cell.oe_group_right
1839 padding-left: 20px1839 padding-left: 20px
1840 .oe_form_group_cell.oe_group_left
1841 padding-left: 0px
1840 // }}}1842 // }}}
1841 // FormView.label {{{1843 // FormView.label {{{
1842 .oe_form1844 .oe_form
18431845
=== modified file 'addons/web/static/src/js/view_form.js'
--- addons/web/static/src/js/view_form.js 2013-10-28 15:00:19 +0000
+++ addons/web/static/src/js/view_form.js 2013-11-11 05:45:18 +0000
@@ -1451,6 +1451,12 @@
1451 }1451 }
1452 $group.before($new_group).remove();1452 $group.before($new_group).remove();
14531453
1454 $table.find('td.oe_group_right').each(function() {
1455 if ($(this).prev().hasClass('oe_form_invisible')) {
1456 $(this).toggleClass('oe_group_left','oe_group_right');
1457 }
1458 });
1459
1454 $table.find('> tbody > tr').each(function() {1460 $table.find('> tbody > tr').each(function() {
1455 var to_compute = [],1461 var to_compute = [],
1456 row_cols = cols,1462 row_cols = cols,
@@ -1755,6 +1761,7 @@
1755 },1761 },
1756 _check_visibility: function() {1762 _check_visibility: function() {
1757 this.$el.toggleClass('oe_form_invisible', this.get("effective_invisible"));1763 this.$el.toggleClass('oe_form_invisible', this.get("effective_invisible"));
1764 this.$el.next().toggleClass('oe_group_left','oe_group_right');
1758 },1765 },
1759};1766};
17601767