Merge lp:~openerp-dev/openerp-web/trunk-fix-manage-view into lp:openerp-web

Proposed by Thibault Delavallée (OpenERP)
Status: Rejected
Rejected by: Thibault Delavallée (OpenERP)
Proposed branch: lp:~openerp-dev/openerp-web/trunk-fix-manage-view
Merge into: lp:openerp-web
Diff against target: 19 lines (+3/-5)
1 file modified
addons/web_view_editor/static/src/js/view_editor.js (+3/-5)
To merge this branch: bzr merge lp:~openerp-dev/openerp-web/trunk-fix-manage-view
Reviewer Review Type Date Requested Status
Thibault Delavallée (OpenERP) (community) Approve
OpenERP R&D Web Team Pending
Review via email: mp+206680@code.launchpad.net

Description of the change

[FIX] view editor: unable to select a different view

To post a comment you must log in.
Revision history for this message
Thibault Delavallée (OpenERP) (tde-openerp) wrote :

Hello,

Seems correct; however I will backport it to saas-3.

review: Approve
Revision history for this message
Thibault Delavallée (OpenERP) (tde-openerp) wrote :

(note: set as rejected because there isn't any other suitable option)

Revision history for this message
Luis Gondelles (luis-gondelles) wrote :

FUCK YOU ALL.... REMOVE ME FROM DISTRIBUTION LIST!!!!!

Sent from my iPad

> On 17/02/2014, at 07:31, Thibault Delavallée (OpenERP) <email address hidden> wrote:
>
> The proposal to merge lp:~openerp-dev/openerp-web/trunk-fix-manage-view into lp:openerp-web has been updated.
>
> Status: Needs review => Work in progress
>
> For more details, see:
> https://code.launchpad.net/~openerp-dev/openerp-web/trunk-fix-manage-view/+merge/206680
> --
> https://code.launchpad.net/~openerp-dev/openerp-web/trunk-fix-manage-view/+merge/206680
> You are subscribed to branch lp:openerp-web.

Unmerged revisions

3917. By Vidhin Mehta (OpenERP)

[FIX]manage view.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'addons/web_view_editor/static/src/js/view_editor.js'
2--- addons/web_view_editor/static/src/js/view_editor.js 2013-04-05 08:52:24 +0000
3+++ addons/web_view_editor/static/src/js/view_editor.js 2014-02-17 10:40:50 +0000
4@@ -73,12 +73,10 @@
5 $.when(this.action_manager.do_action(action)).done(function() {
6 var viewmanager = self.action_manager.inner_widget;
7 var controller = viewmanager.views[viewmanager.active_view].controller;
8- controller.on('view_loaded', self, function(){
9- $(controller.groups).bind({
10- 'selected': function(e, ids, records) {
11+ $(controller.groups).bind({
12+ 'selected': function (e, ids, records, deselected) {
13 self.main_view_id = ids[0];
14- }
15- });
16+ }
17 });
18 });
19 },