Code review comment for lp:~openerp-dev/openerp-web/trunk-customize_kanban-pan
Revision history for this message
| Nicolas Vanhoren (OpenERP) (niv-openerp) wrote | # |
review:
Disapprove
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
35a32c5
(Get the code!)
- You must not modify an existing library, ever.
- The file formats.js is not dedicated to that kind of stuff. It should not be altered in any way.
- I don't like the whole idea of creating new field types for just a legend, I think that feature should be re-created by one of the persons responsible of the web client.