Merge lp:~openerp-dev/openerp-web/trunk-bug-869746-vda into lp:openerp-web

Proposed by Vaibhav Darji
Status: Rejected
Rejected by: Xavier (Open ERP)
Proposed branch: lp:~openerp-dev/openerp-web/trunk-bug-869746-vda
Merge into: lp:openerp-web
Diff against target: 30 lines (+10/-3)
1 file modified
addons/web/static/src/js/view_list.js (+10/-3)
To merge this branch: bzr merge lp:~openerp-dev/openerp-web/trunk-bug-869746-vda
Reviewer Review Type Date Requested Status
Xavier (Open ERP) (community) Disapprove
Review via email: mp+78701@code.launchpad.net

Description of the change

Type cast for Action button.
columns contain field action `id|name` as a string but as an Integer on field data attributes.
And At last when do_execute_action performs action, parse action.name.

To post a comment you must log in.
Revision history for this message
Xavier (Open ERP) (xmo-deactivatedaccount) wrote :

Far's I can tell, merge proposal 76560 to fix bug 851866 has a simpler fix for the same problem. So I'll go with that one.

review: Disapprove

Unmerged revisions

1184. By Vaibhav Darji

[FIX] type cast for Action button.When we render node,contains action id,name as a string.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'addons/web/static/src/js/view_list.js'
--- addons/web/static/src/js/view_list.js 2011-10-07 07:17:56 +0000
+++ addons/web/static/src/js/view_list.js 2011-10-08 08:21:25 +0000
@@ -712,7 +712,11 @@
712 this.columns = opts.columns;712 this.columns = opts.columns;
713 this.dataset = opts.dataset;713 this.dataset = opts.dataset;
714 this.records = opts.records;714 this.records = opts.records;
715715
716 this.visible_columns = _.filter(this.columns, function (column) {
717 return column.invisible !== '1';
718 });
719
716 this.record_callbacks = {720 this.record_callbacks = {
717 'remove': function (event, record) {721 'remove': function (event, record) {
718 var $row = self.$current.find(722 var $row = self.$current.find(
@@ -765,8 +769,11 @@
765 var $target = $(e.currentTarget),769 var $target = $(e.currentTarget),
766 field = $target.closest('td').data('field'),770 field = $target.closest('td').data('field'),
767 $row = $target.closest('tr'),771 $row = $target.closest('tr'),
768 record_id = self.row_id($row);772 field_action = self.visible_columns[$target.closest('td').index()],
769773 record_id = self.row_id($row);
774
775 if(field_action.type == 'action') field = field.toString();
776
770 $(self).trigger('action', [field, record_id, function () {777 $(self).trigger('action', [field, record_id, function () {
771 return self.reload_record(self.records.get(record_id));778 return self.reload_record(self.records.get(record_id));
772 }]);779 }]);