Merge lp:~openerp-dev/openerp-web/trunk-bug-1082616-ggh into lp:openerp-web

[Farid Ghanchi]

Hello,

>>> Not get the filename so i have get the filename in view.datarecord

>>>step:
1. Install new module OpenERP Reprot Designer
2. During installation process, clicking to download openerp_report_designer.zip package.
3. Error display.....

Thanks...

[Xavier (Open ERP) (xmo-deactivatedaccount)]

1. where the hell does that link content change come from?
2. I'm not convinced this is the best place to go and fetch the current file's name…

review: Disapprove

[lp:~openerp-dev/openerp-web/trunk-bug-1082616-ggh]

3512. By Farid Ghanchi on 2012-11-29

[Fix] fixed the issue can't download openerp report designer

[Farid Ghanchi (gfarid)]

Hello

widget had set effective_readonly so set oe_form_uri class

In this issue widget is set effective readonly so no get the oe_form_binary_file_save_data
so check the condition and class will be find
I hope this code is usefull

Thanks....

review: Needs Resubmitting

[Fabien Meghazi (OpenERP) (fme)]

Fixed in trunk's Revision:
3589 revid:<email address hidden>

Unmerged revisions

3512. By Farid Ghanchi on 2012-11-29

[Fix] fixed the issue can't download openerp report designer

3511. By Farid Ghanchi on 2012-11-28

[Fix] Fixed the issue of Can't download openerp_report_designer.zip package

=== modified file 'addons/web/static/src/js/view_form.js'
--- addons/web/static/src/js/view_form.js	2012-11-28 13:50:13 +0000
+++ addons/web/static/src/js/view_form.js	2012-11-29 06:21:19 +0000
@@ -4858,8 +4858,8 @@
             this.do_warn(_t("Save As..."), _t("The field is empty, there's nothing to save !"));
             ev.stopPropagation();
         } else if (this._dirty_flag) {
-            var link = this.$('.oe_form_binary_file_save_data')[0];
-            link.download = this.filename || "download.bin"; // Works on only on Google Chrome
+            var link = (this.get("effective_readonly")) ? this.$('.oe_form_uri')[0]:this.$('.oe_form_binary_file_save_data')[0];
+            link.download = (this.filename ? this.filename : this.view.datarecord[this.node.attrs.filename]) || "download.bin"; // Works on only on Google Chrome
             //link.target = '_blank';
             link.href = "data:application/octet-stream;base64," + value;
         } else {
@@ -4908,7 +4908,7 @@
                 if (self.get('value')) {
                     self.on_save_as(ev);
                 }
-                return false;
+                return true;
             });
         }
     },