Merge lp:~openerp-dev/openerp-web/7.0-opw-595981-msh into lp:openerp-web/7.0

Proposed by Mohammed Shekha(Open ERP)
Status: Needs review
Proposed branch: lp:~openerp-dev/openerp-web/7.0-opw-595981-msh
Merge into: lp:openerp-web/7.0
Diff against target: 12 lines (+0/-2)
1 file modified
addons/web_kanban/static/src/js/kanban.js (+0/-2)
To merge this branch: bzr merge lp:~openerp-dev/openerp-web/7.0-opw-595981-msh
Reviewer Review Type Date Requested Status
Martin Trigaux (OpenERP) Pending
Xavier (Open ERP) Pending
Review via email: mp+177740@code.launchpad.net

Description of the change

Hello,

Fixed the issue of kanban not shows exception message, instead it shows static message, rpc fail already shows error popup so there is not need of special alert.

Demo: Override write for any object for which kanban view is developed, raise exception with your message from write, move kanban box from one state to another so that exception raised.

Result: Alert box instead of error popup.
Expected: error popup should come with defined message.

Thanks.

To post a comment you must log in.

Unmerged revisions

4008. By Mohammed Shekha<email address hidden>

[FIX]Fixed the issue of kanban not shows exception message, instead it shows static message, rpc fail already shows error popup so there is not need of special alert.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'addons/web_kanban/static/src/js/kanban.js'
--- addons/web_kanban/static/src/js/kanban.js 2013-04-30 09:48:43 +0000
+++ addons/web_kanban/static/src/js/kanban.js 2013-07-31 05:37:27 +0000
@@ -420,8 +420,6 @@
420 record.do_reload();420 record.do_reload();
421 new_group.do_save_sequences();421 new_group.do_save_sequences();
422 }).fail(function(error, evt) {422 }).fail(function(error, evt) {
423 evt.preventDefault();
424 alert(_t("An error has occured while moving the record to this group: ") + data.fault_code);
425 self.do_reload(); // TODO: use draggable + sortable in order to cancel the dragging when the rcp fails423 self.do_reload(); // TODO: use draggable + sortable in order to cancel the dragging when the rcp fails
426 });424 });
427 }425 }