Odoo Web (MOVED TO GITHUB)

Code review comment for lp:~openerp-dev/openerp-web/7.0-opw-586295-msh

  1. 7.0-opw-586295-msh
  2. Merge into 7.0
Revision history for this message
Mohammed Shekha(Open ERP) (msh-openerp) wrote :

Hello Xavier,

Thanks for the review.

Initially field_View get called and we will not have buttons in this object, but while grouping data again list reloaded but now this time we will have $buttons in this object so it is not going to be inside if(see line 233 view_list.js) so button is not going to be disabled as prop is inside if, also click shoild binded single time so keep it as it is, just put prop outside if there are this.$button available.

Thanks.

review: Needs Resubmitting
Reply

« Back to merge proposal