Odoo Web (MOVED TO GITHUB)

Code review comment for lp:~openerp-dev/openerp-web/7.0-integer-fields-search-odo

  1. 7.0-integer-fields-search-odo
  2. Merge into 7.0
Revision history for this message
Xavier (Open ERP) (xmo-deactivatedaccount) wrote :

* probably no need to escape the value: after parse() has run, we've got either an actual number or a NaN which gets filtered out, numbers shouldn't be able to contain HTML.
* not completing on !val means we can't complete on a 0, is that normal?
* could benefit from a new test or two in search.completions, they seem to be missing.

review: Needs Fixing

« Back to merge proposal