Merge lp:~openerp-dev/openerp-web/7.0-improve-searchbox-cursor-bth-psa into lp:openerp-web/7.0

Proposed by Paramjit Singh Sahota(OpenERP)
Status: Superseded
Proposed branch: lp:~openerp-dev/openerp-web/7.0-improve-searchbox-cursor-bth-psa
Merge into: lp:openerp-web/7.0
Diff against target: 39 lines (+2/-2)
2 files modified
addons/web/static/src/css/base.css (+1/-1)
addons/web/static/src/css/base.sass (+1/-1)
To merge this branch: bzr merge lp:~openerp-dev/openerp-web/7.0-improve-searchbox-cursor-bth-psa
Reviewer Review Type Date Requested Status
Xavier (Open ERP) (community) Needs Fixing
Review via email: mp+154317@code.launchpad.net

This proposal has been superseded by a proposal from 2013-05-17.

Description of the change

Hello,

Fixed the issue,
>In the search box, when you do a advanced filter, the "or" seems clickable (hand cursor) but it is not, it is confusing.
>The "or" should not be clickable.

Thankz YoU.
 -PSA.

To post a comment you must log in.
3855. By bth <bth@bth-laptop>

[MERGE] Merge lp:openerp-web/7.0.

3856. By bth <bth@bth-laptop>

[FIX] Put arrow on or.

3857. By Bhumi Thakkar (Open ERP)

[MERGE] Merge lp:openerp-web/7.0.

Revision history for this message
Xavier (Open ERP) (xmo-deactivatedaccount) wrote :

Change is overly complex, why not just remove `cursor` on `.openerp .oe_searchview .oe_searchview_drawer .oe_searchview_advanced li` and then set `cursor:default` on `.openerp .oe_searchview .oe_searchview_drawer` (to offset `cursor:text` set on `.oe_searchview`)?

review: Needs Fixing
3858. By Paramjit Singh Sahota(OpenERP)

[MERGE] Merged lp:openerp-web/7.0

3859. By Paramjit Singh Sahota(OpenERP)

[IMP] Removed 'cursor on '.openerp .oe_searchview .oe_searchview_drawer .oe_searchview_advanced li' and then added 'cursor:default' on '.openerp .oe_searchview .oe_searchview_drawer'.

3860. By Bhumi Thakkar (Open ERP)

[MERGE]Merge lp:openerp-web/7.0

Unmerged revisions

3860. By Bhumi Thakkar (Open ERP)

[MERGE]Merge lp:openerp-web/7.0

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'addons/web/static/src/css/base.css'
--- addons/web/static/src/css/base.css 2013-04-04 10:23:06 +0000
+++ addons/web/static/src/css/base.css 2013-05-17 06:27:27 +0000
@@ -1812,6 +1812,7 @@
1812 display: block;1812 display: block;
1813}1813}
1814.openerp .oe_searchview .oe_searchview_drawer {1814.openerp .oe_searchview .oe_searchview_drawer {
1815 cursor: default;
1815 position: absolute;1816 position: absolute;
1816 z-index: 2;1817 z-index: 2;
1817 margin-top: 4px;1818 margin-top: 4px;
@@ -1958,7 +1959,6 @@
1958 padding: 0;1959 padding: 0;
1959}1960}
1960.openerp .oe_searchview .oe_searchview_drawer .oe_searchview_advanced li {1961.openerp .oe_searchview .oe_searchview_drawer .oe_searchview_advanced li {
1961 cursor: pointer;
1962 position: relative;1962 position: relative;
1963 list-style: none;1963 list-style: none;
1964 margin: 0;1964 margin: 0;
19651965
=== modified file 'addons/web/static/src/css/base.sass'
--- addons/web/static/src/css/base.sass 2013-04-04 10:23:06 +0000
+++ addons/web/static/src/css/base.sass 2013-05-17 06:27:27 +0000
@@ -1441,6 +1441,7 @@
1441 display: block1441 display: block
14421442
1443 .oe_searchview_drawer1443 .oe_searchview_drawer
1444 cursor: default
1444 position: absolute1445 position: absolute
1445 z-index: 21446 z-index: 2
1446 // detach drawer from field slightly1447 // detach drawer from field slightly
@@ -1554,7 +1555,6 @@
1554 list-style: none1555 list-style: none
1555 padding: 01556 padding: 0
1556 li1557 li
1557 cursor: pointer
1558 position: relative1558 position: relative
1559 list-style: none1559 list-style: none
1560 margin: 01560 margin: 0