Merge lp:~openerp-dev/openerp-web/7.0-fix-push-state-chs into lp:openerp-web/7.0

[Fabien Meghazi (OpenERP)]

This branch contains a patch from chs fixing the WTF bug of integers as string in push states.

It also has an improvement in order to make urls shorter by omitting the active_ids in the state if it's equal to a single element array containing the active_id.

[Christophe Simonis (OpenERP) (kangol)]

review: Approve

=== modified file 'addons/web/static/src/js/chrome.js'
--- addons/web/static/src/js/chrome.js	2013-02-13 14:39:53 +0000
+++ addons/web/static/src/js/chrome.js	2013-02-20 09:23:32 +0000
@@ -1323,8 +1323,9 @@
     },
     on_hashchange: function(event) {
         var self = this;
-        var state = event.getState(true);
-        if (!_.isEqual(this._current_state, state)) {
+        var stringstate = event.getState(false);
+        if (!_.isEqual(this._current_state, stringstate)) {
+            var state = event.getState(true);
             if(!state.action && state.menu_id) {
                 self.menu.has_been_loaded.done(function() {
                     self.menu.do_reload().done(function() {
@@ -1336,13 +1337,13 @@
                 this.action_manager.do_load_state(state, !!this._current_state);
             }
         }
-        this._current_state = state;
+        this._current_state = stringstate;
     },
     do_push_state: function(state) {
         this.set_title(state.title);
         delete state.title;
         var url = '#' + $.param(state);
-        this._current_state = _.clone(state);
+        this._current_state = $.deparam($.param(state), false);     // stringify all values
         $.bbq.pushState(url);
         this.trigger('state_pushed', state);
     },
 
=== modified file 'addons/web/static/src/js/views.js'
--- addons/web/static/src/js/views.js	2013-02-19 18:15:19 +0000
+++ addons/web/static/src/js/views.js	2013-02-20 09:23:32 +0000
@@ -191,11 +191,15 @@
                     state = _.extend(params || {}, state);
                 }
                 if (this.inner_action.context) {
-                    if (this.inner_action.context.active_id) {
-                        state["active_id"] = this.inner_action.context.active_id;
+                    var active_id = this.inner_action.context.active_id;
+                    if (active_id) {
+                        state["active_id"] = active_id;
                     }
-                    if (this.inner_action.context.active_ids) {
-                        //state["active_ids"] = this.inner_action.context.active_ids.join(',');
+                    var active_ids = this.inner_action.context.active_ids;
+                    if (active_ids && !(active_ids.length === 1 && active_ids[0] === active_id)) {
+                        // We don't push active_ids if it's a single element array containing the active_id
+                        // This makes the url shorter in most cases.
+                        state["active_ids"] = this.inner_action.context.active_ids.join(',');
                     }
                 }
             }
@@ -231,6 +235,8 @@
                         add_context.active_ids = state.active_ids.toString().split(',').map(function(id) {
                             return parseInt(id, 10) || id;
                         });
+                    } else if (state.active_id) {
+                        add_context.active_ids = [state.active_id];
                     }
                     this.null_action();
                     action_loaded = this.do_action(state.action, { additional_context: add_context });