Code review comment for lp:~openerp-dev/openerp-web/7.0-bug-1097757-ggh

Revision history for this message
Xavier (Open ERP) (xmo-deactivatedaccount) wrote :

1. Why are you still doing a match on the querystring instead of using $.deparam.querystring, which returns a parsed and structured object?
2. The current JS code "untranslates" terms
3. Why is there a reference to "window.location.hash" to deactivate the developer mode? Also why do you check for the devmode status based on the label of a button instead of checking the actual devmode status (which you're supposed to have already done once above, so you could just memoize that)

review: Needs Fixing

« Back to merge proposal