Merge lp:~openerp-dev/openerp-web/7.0-bug-1097219-bth into lp:openerp-web/7.0

Proposed by Bhumi Thakkar (Open ERP)
Status: Rejected
Rejected by: Xavier (Open ERP)
Proposed branch: lp:~openerp-dev/openerp-web/7.0-bug-1097219-bth
Merge into: lp:openerp-web/7.0
Diff against target: 42 lines (+7/-7)
2 files modified
addons/web_kanban/static/src/css/kanban.css (+1/-1)
addons/web_kanban/static/src/css/kanban.sass (+6/-6)
To merge this branch: bzr merge lp:~openerp-dev/openerp-web/7.0-bug-1097219-bth
Reviewer Review Type Date Requested Status
Xavier (Open ERP) (community) Disapprove
Review via email: mp+142842@code.launchpad.net

Description of the change

Hello,

    (In Firefox) Fixed issue of Clicking on the empty space (far right) of the kanban view changes the dom.

To Reproduce:

1. Sales => Sales => Opportunities
2. Select Salesperson of groupby from searchview.
3. click on empty area of right side of group kanban view.

Observed: Height of kanban group is increased.

Thanks.

To post a comment you must log in.
Revision history for this message
Xavier (Open ERP) (xmo-deactivatedaccount) wrote :

This breaks the kanban groups taking the full height of the kanban view, leaving an unsightly white space below the columns.

review: Disapprove

Unmerged revisions

3698. By Bhumi Thakkar (Open ERP)

[FIX] Fixed issue of click on empty area in kanban groups height is increased of groups in kanban.--fixes:lp1097219

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'addons/web_kanban/static/src/css/kanban.css'
--- addons/web_kanban/static/src/css/kanban.css 2013-01-09 09:44:51 +0000
+++ addons/web_kanban/static/src/css/kanban.css 2013-01-11 07:15:25 +0000
@@ -56,7 +56,7 @@
56 background: #dc5f59;56 background: #dc5f59;
57}57}
58.openerp .oe_kanban_view .oe_kanban_groups {58.openerp .oe_kanban_view .oe_kanban_groups {
59 height: inherit;59 height: auto;
60}60}
61.openerp .oe_kanban_view.oe_kanban_ungrouped .oe_kanban_groups {61.openerp .oe_kanban_view.oe_kanban_ungrouped .oe_kanban_groups {
62 width: 100%;62 width: 100%;
6363
=== modified file 'addons/web_kanban/static/src/css/kanban.sass'
--- addons/web_kanban/static/src/css/kanban.sass 2013-01-09 09:44:51 +0000
+++ addons/web_kanban/static/src/css/kanban.sass 2013-01-11 07:15:25 +0000
@@ -89,7 +89,7 @@
89 // }}}89 // }}}
90 // KanbanGroups {{{90 // KanbanGroups {{{
91 .oe_kanban_groups91 .oe_kanban_groups
92 height: inherit92 height: auto
93 &.oe_kanban_ungrouped .oe_kanban_groups93 &.oe_kanban_ungrouped .oe_kanban_groups
94 width: 100%94 width: 100%
95 &.oe_kanban_grouped_by_m2o .oe_kanban_group_title95 &.oe_kanban_grouped_by_m2o .oe_kanban_group_title
@@ -119,11 +119,11 @@
119 overflow: hidden119 overflow: hidden
120 text-overflow: ellipsis120 text-overflow: ellipsis
121 .oe_kanban_group_length121 .oe_kanban_group_length
122 position: absolute122 position: absolute
123 top: -1px123 top: -1px
124 right: -14px124 right: -14px
125 text-align: center125 text-align: center
126 float: right126 float: right
127 &.oe_kanban_grouped127 &.oe_kanban_grouped
128 .oe_kanban_column, .oe_kanban_group_header128 .oe_kanban_column, .oe_kanban_group_header
129 width: 185px129 width: 185px