Merge lp:~openerp-dev/openerp-web/7.0-bug-1097219-bth into lp:openerp-web/7.0

Proposed by Bhumi Thakkar (Open ERP)
Status: Rejected
Rejected by: Xavier (Open ERP)
Proposed branch: lp:~openerp-dev/openerp-web/7.0-bug-1097219-bth
Merge into: lp:openerp-web/7.0
Diff against target: 42 lines (+7/-7)
2 files modified
addons/web_kanban/static/src/css/kanban.css (+1/-1)
addons/web_kanban/static/src/css/kanban.sass (+6/-6)
To merge this branch: bzr merge lp:~openerp-dev/openerp-web/7.0-bug-1097219-bth
Reviewer Review Type Date Requested Status
Xavier (Open ERP) (community) Disapprove
Review via email: mp+142842@code.launchpad.net

Description of the change

Hello,

    (In Firefox) Fixed issue of Clicking on the empty space (far right) of the kanban view changes the dom.

To Reproduce:

1. Sales => Sales => Opportunities
2. Select Salesperson of groupby from searchview.
3. click on empty area of right side of group kanban view.

Observed: Height of kanban group is increased.

Thanks.

To post a comment you must log in.
Revision history for this message
Xavier (Open ERP) (xmo-deactivatedaccount) wrote :

This breaks the kanban groups taking the full height of the kanban view, leaving an unsightly white space below the columns.

review: Disapprove

Unmerged revisions

3698. By Bhumi Thakkar (Open ERP)

[FIX] Fixed issue of click on empty area in kanban groups height is increased of groups in kanban.--fixes:lp1097219

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'addons/web_kanban/static/src/css/kanban.css'
2--- addons/web_kanban/static/src/css/kanban.css 2013-01-09 09:44:51 +0000
3+++ addons/web_kanban/static/src/css/kanban.css 2013-01-11 07:15:25 +0000
4@@ -56,7 +56,7 @@
5 background: #dc5f59;
6 }
7 .openerp .oe_kanban_view .oe_kanban_groups {
8- height: inherit;
9+ height: auto;
10 }
11 .openerp .oe_kanban_view.oe_kanban_ungrouped .oe_kanban_groups {
12 width: 100%;
13
14=== modified file 'addons/web_kanban/static/src/css/kanban.sass'
15--- addons/web_kanban/static/src/css/kanban.sass 2013-01-09 09:44:51 +0000
16+++ addons/web_kanban/static/src/css/kanban.sass 2013-01-11 07:15:25 +0000
17@@ -89,7 +89,7 @@
18 // }}}
19 // KanbanGroups {{{
20 .oe_kanban_groups
21- height: inherit
22+ height: auto
23 &.oe_kanban_ungrouped .oe_kanban_groups
24 width: 100%
25 &.oe_kanban_grouped_by_m2o .oe_kanban_group_title
26@@ -119,11 +119,11 @@
27 overflow: hidden
28 text-overflow: ellipsis
29 .oe_kanban_group_length
30- position: absolute
31- top: -1px
32- right: -14px
33- text-align: center
34- float: right
35+ position: absolute
36+ top: -1px
37+ right: -14px
38+ text-align: center
39+ float: right
40 &.oe_kanban_grouped
41 .oe_kanban_column, .oe_kanban_group_header
42 width: 185px