Merge lp:~openerp-dev/openerp-web/7.0-bug-1095976-psa into lp:openerp-web/7.0

Proposed by Paramjit Singh Sahota(OpenERP)
Status: Rejected
Rejected by: Xavier (Open ERP)
Proposed branch: lp:~openerp-dev/openerp-web/7.0-bug-1095976-psa
Merge into: lp:openerp-web/7.0
Diff against target: 25 lines (+2/-2)
2 files modified
addons/web/static/src/css/base.css (+1/-1)
addons/web/static/src/css/base.sass (+1/-1)
To merge this branch: bzr merge lp:~openerp-dev/openerp-web/7.0-bug-1095976-psa
Reviewer Review Type Date Requested Status
Xavier (Open ERP) (community) Needs Fixing
Review via email: mp+141880@code.launchpad.net

Description of the change

Hello,

Fixed the issue where the background of the Submenu in leftbar breaks out from the leftbar.
> bad size background button Edit

Thankz YoU.
 -PSA.

To post a comment you must log in.
Revision history for this message
Xavier (Open ERP) (xmo-deactivatedaccount) wrote :

Now there's a big hole to the right of the menu item. Have you considered that this may not be better or more correct than going "through"? http://hfr-rehost.net/self/81be1811c1cd9440c160b9eda5c6f443bf22c8fc.png

review: Needs Fixing
Revision history for this message
Xavier (Open ERP) (xmo-deactivatedaccount) wrote :

https://code.launchpad.net/~openerp-dev/openerp-web/7.0-bug-1098574-bth/+merge/143266 looks like a better fix of the same issue, so rejecting this one.

Unmerged revisions

3683. By Paramjit Singh Sahota(OpenERP)

[FIX][7.0]bad size background button Edit

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'addons/web/static/src/css/base.css'
--- addons/web/static/src/css/base.css 2013-01-03 17:42:14 +0000
+++ addons/web/static/src/css/base.css 2013-01-04 10:21:21 +0000
@@ -1242,7 +1242,7 @@
1242.openerp .oe_secondary_submenu {1242.openerp .oe_secondary_submenu {
1243 padding: 2px 0 8px 0;1243 padding: 2px 0 8px 0;
1244 margin: 0;1244 margin: 0;
1245 width: 220px;1245 width: 100%;
1246 display: inline-block;1246 display: inline-block;
1247}1247}
1248.openerp .oe_secondary_submenu li {1248.openerp .oe_secondary_submenu li {
12491249
=== modified file 'addons/web/static/src/css/base.sass'
--- addons/web/static/src/css/base.sass 2013-01-03 17:42:14 +0000
+++ addons/web/static/src/css/base.sass 2013-01-04 10:21:21 +0000
@@ -1009,7 +1009,7 @@
1009 .oe_secondary_submenu1009 .oe_secondary_submenu
1010 padding: 2px 0 8px 01010 padding: 2px 0 8px 0
1011 margin: 01011 margin: 0
1012 width: 220px1012 width: 100%
1013 display: inline-block1013 display: inline-block
1014 li1014 li
1015 position: relative1015 position: relative