Merge lp:~openerp-dev/openerp-web/7.0-bug-1089871-bth into lp:openerp-web/7.0

Proposed by Bhumi Thakkar (Open ERP)
Status: Rejected
Rejected by: Christophe Matthieu (OpenERP)
Proposed branch: lp:~openerp-dev/openerp-web/7.0-bug-1089871-bth
Merge into: lp:openerp-web/7.0
Diff against target: 26 lines (+5/-0)
2 files modified
addons/web/static/src/css/base.css (+3/-0)
addons/web/static/src/css/base.sass (+2/-0)
To merge this branch: bzr merge lp:~openerp-dev/openerp-web/7.0-bug-1089871-bth
Reviewer Review Type Date Requested Status
Christophe Matthieu (OpenERP) (community) Disapprove
Review via email: mp+144268@code.launchpad.net

Description of the change

Hello,

   Fixed issue of UI in Sales/Quotations and Sales/Sale Orders in other information tab.

To Reproduce:
1. Sales => Sales => Quotations or Sales => Sales => Sale Orders
2. Create any record select tab Other Information

Observed: UI or layout of field categories and Invoice Type is not proper.
Expected: UI or layout should proper.

In text-core class get height: 0 when create record so overwrite that class given by height with !important.

Thanks.

To post a comment you must log in.
Revision history for this message
Christophe Matthieu (OpenERP) (chm-openerp) wrote :

Hi,
It's a wrong fix, textext set the size box according of the initial size of the textarea. Do not fixe with important the text-warp height.

I fixed this in 7.0 like this:
.openerp .oe_tags .text-wrap textarea {
  width: 100% !important;
+ min-height: 22px;
}

review: Disapprove

Unmerged revisions

3709. By Bhumi Thakkar (Open ERP)

[FIX] Overwrite css class text-core.--fixes:lp1089871

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'addons/web/static/src/css/base.css'
--- addons/web/static/src/css/base.css 2013-01-09 13:18:48 +0000
+++ addons/web/static/src/css/base.css 2013-01-22 10:47:20 +0000
@@ -550,6 +550,9 @@
550.openerp .oe_tags .text-wrap textarea {550.openerp .oe_tags .text-wrap textarea {
551 width: 100% !important;551 width: 100% !important;
552}552}
553.openerp .oe_tags .text-core {
554 height: 22px !important;
555}
553.openerp .oe_tags .text-core .text-wrap .text-dropdown .text-list .text-suggestion em {556.openerp .oe_tags .text-core .text-wrap .text-dropdown .text-list .text-suggestion em {
554 font-style: italic;557 font-style: italic;
555 text-decoration: none;558 text-decoration: none;
556559
=== modified file 'addons/web/static/src/css/base.sass'
--- addons/web/static/src/css/base.sass 2013-01-09 13:18:48 +0000
+++ addons/web/static/src/css/base.sass 2013-01-22 10:47:20 +0000
@@ -484,6 +484,8 @@
484 width: 100% !important484 width: 100% !important
485 textarea485 textarea
486 width: 100% !important486 width: 100% !important
487 .text-core
488 height: 22px !important
487 .text-core .text-wrap .text-dropdown .text-list .text-suggestion em489 .text-core .text-wrap .text-dropdown .text-list .text-suggestion em
488 font-style: italic490 font-style: italic
489 text-decoration: none491 text-decoration: none