Merge lp:~openerp-dev/openerp-web/6.1-opw-576040-cpa into lp:openerp-web/6.1

[Chirag Patel (OpenERP)]

Hello,

Gantt chart not show right duration when date_delay provide.

Demo: Sales > Meetings > Meetings
1) Switch to Gantt view.

Observed: Event bar show wrong duration.
Observed: Tooltip not show when mouse hover on event bar and event duration < 4 hours

For tooltip

Add event description (displayed right after the event bar).
Tooltip show when mouse hover on event description.

Thanks

[lp:~openerp-dev/openerp-web/6.1-opw-576040-cpa]

2379. By Chirag Patel (OpenERP) on 2012-07-10

[FIX] Fixed format_value change the duration decimal separator.

[Chirag Patel (OpenERP) (cpa-openerp)]

In revision : 2379

format_value change the value from "." to "," when decimal separator "," and duration not set for any event.
Here no need to change format of duration.

[lp:~openerp-dev/openerp-web/6.1-opw-576040-cpa]

2380. By Chirag Patel (OpenERP) on 2012-07-16

[FIX] Fixed Gantt chart support day_length attr.

[Chirag Patel (OpenERP) (cpa-openerp)]

In revision : 2380

Gantt chart default set "8" as working hours(day_length)
and not support day_length, set by the user in xml.

[Jiten (OpenERP) (jiten-openerp)]

review: Approve

Unmerged revisions

2380. By Chirag Patel (OpenERP) on 2012-07-16

[FIX] Fixed Gantt chart support day_length attr.

2379. By Chirag Patel (OpenERP) on 2012-07-10

[FIX] Fixed format_value change the duration decimal separator.

2378. By Chirag Patel (OpenERP) on 2012-06-28

[FIX] Fixed gantt chart not show right duration when date_delay provide.

=== modified file 'addons/web_gantt/static/lib/dhtmlxGantt/sources/dhtmlxgantt.js'
--- addons/web_gantt/static/lib/dhtmlxGantt/sources/dhtmlxgantt.js	2012-07-02 13:30:16 +0000
+++ addons/web_gantt/static/lib/dhtmlxGantt/sources/dhtmlxgantt.js	2012-07-16 09:04:21 +0000
@@ -348,7 +348,7 @@
  *  @type: public
  *  @topic: 0
  */
-function GanttChart()
+function GanttChart(day_length)
 {
     this.Error = new GanttError();
     this.dhtmlXMLSenderObject = new dhtmlXMLSenderObject(this);
@@ -356,7 +356,7 @@
     //settings
     this.heightTaskItem = 12;
     this.dayInPixels = 24;
-    this.hoursInDay = 8;
+    this.hoursInDay = day_length;
     this._showTreePanel = true;
     this._showTooltip = true;
     this.isShowDescTask = false;
 
=== modified file 'addons/web_gantt/static/src/js/gantt.js'
--- addons/web_gantt/static/src/js/gantt.js	2012-01-27 16:06:45 +0000
+++ addons/web_gantt/static/src/js/gantt.js	2012-07-16 09:04:21 +0000
@@ -60,6 +60,7 @@
     on_data_loaded: function(tasks, group_bys) {
         var self = this;
         var ids = _.pluck(tasks, "id");
+        day_length = self.fields_view.arch.attrs.day_length || 8;
         return this.dataset.name_get(ids).pipe(function(names) {
             var ntasks = _.map(tasks, function(task) {
                 return _.extend({__name: _.detect(names, function(name) { return name[0] == task.id; })[1]}, task); 
@@ -147,26 +148,28 @@
                     task_stop = openerp.web.auto_str_to_date(task[self.fields_view.arch.attrs.date_stop]);
                     if (!task_stop)
                         return;
+                    var duration = (task_stop.getTime() - task_start.getTime()) / (1000 * 60 * 60);
+                    duration = ((duration / 24) * day_length);
                 } else { // we assume date_duration is defined
-                    var tmp = openerp.web.format_value(task[self.fields_view.arch.attrs.date_delay],
-                        self.fields[self.fields_view.arch.attrs.date_delay]);
+                    var tmp = task[self.fields_view.arch.attrs.date_delay];
                     if (!tmp)
                         return;
                     task_stop = task_start.clone().addMilliseconds(tmp * 60 * 60 * 1000);
+                    var duration = tmp;
                 }
-                var duration = (task_stop.getTime() - task_start.getTime()) / (1000 * 60 * 60);
                 var id = _.uniqueId("gantt_task_");
-                var task_info = new GanttTaskInfo(id, task_name, task_start, ((duration / 24) * 8), 100);
+                var task_info = new GanttTaskInfo(id, task_name, task_start, duration, 100);
                 task_info.internal_task = task;
                 task_ids[id] = task_info;
                 return {task_info: task_info, task_start: task_start, task_stop: task_stop};
             }
         }
-        var gantt = new GanttChart();
+        var gantt = new GanttChart(day_length);
         _.each(_.compact(_.map(groups, function(e) {return generate_task_info(e, 0);})), function(project) {
             gantt.addProject(project);
         });
         gantt.setEditable(true);
+        gantt.showDescTask(true,'s-f');
         gantt.setImagePath("/web_gantt/static/lib/dhtmlxGantt/codebase/imgs/");
         gantt.attachEvent("onTaskEndDrag", function(task) {
             self.on_task_changed(task);
@@ -194,15 +197,16 @@
         var self = this;
         var itask = task_obj.TaskInfo.internal_task;
         var start = task_obj.getEST();
-        var duration = (task_obj.getDuration() / 8) * 24;
-        var end = start.clone().addMilliseconds(duration * 60 * 60 * 1000);
         var data = {};
         data[self.fields_view.arch.attrs.date_start] =
             openerp.web.auto_date_to_str(start, self.fields[self.fields_view.arch.attrs.date_start].type);
         if (self.fields_view.arch.attrs.date_stop) {
+            var duration = (task_obj.getDuration() / day_length) * 24;
+            var end = start.clone().addMilliseconds(duration * 60 * 60 * 1000);
             data[self.fields_view.arch.attrs.date_stop] = 
                 openerp.web.auto_date_to_str(end, self.fields[self.fields_view.arch.attrs.date_stop].type);
         } else { // we assume date_duration is defined
+            var duration = task_obj.getDuration();
             data[self.fields_view.arch.attrs.date_delay] = duration;
         }
         this.dataset.write(itask.id, data).then(function() {