Code review comment for lp:~openerp-dev/openerp-doc/trunk-rewrite-build-with-generated-index-xmo

Revision history for this message
Olivier Dony (Odoo) (odo-openerp) wrote :

Please disregard the traceback in my previous comment, I had tried to init the branches manually (using faster local lightweight checkouts) and had not noticed the new `tools` one, which was thus missing.

I actually tried to run ``make init`` afterwards to see whether it would fix it, but it does not work on a partially initialized set of branches. Maybe we could have `init` as a real make target that has `addons`,`web`,`server` and `tools` as prerequisites, each having the corresponding `bzr branch` command. The `init` target could then be a prerequisite for `html`/`dirhtml`, auto-magically fixing your branches when needed.
Of course the same could be done in ./docbuilder, it's just that a Makefile works well for that sort of thing.

Anyhow, this is all just nice-to-have, the current patch is fine by me.

review: Approve

« Back to merge proposal