Code review comment for lp:~openerp-community/server-env-tools/7.0-modules-from-openobject-extension

Revision history for this message
Mario Arias (the-clone-master) wrote :

I just found two small issues:

import_odbc_view:
Line 45: the "tree" is missing the "string" attribute, that is mandatory. Just add 'string="Tree Name"' as attribute and the error will be gone.
Line 81: base.next_id_15 is not present in OpenERP Saas3. Not sure what menu was that, but this is fixed just defining what would be the right menu to place the module under...

Also it seems that base_external_dbsource branch in LP is more "up to date" than included module in this one...
I will check change history and diff, and will publish back any findings...

Regards,
Mario

review: Needs Fixing (code review and test)

« Back to merge proposal