Code review comment for lp:~openerp-community/openobject-server/context-in-workflows

Revision history for this message
Stefan Rijnhart (Opener) (stefan-opener) wrote :

Hi Raphaël,

thanks for the effort! A tiny detail in openerp/workflow/wkf_expr.py, line 133: looks like you lose the context here.

I see the problem with the API change and existing methods that Olivier also points out. However, it is one thing to make all models pass the context when calling the workflow service API, but for 6.1 it might minimally suffice to just make the methods mentioned in wkf_activity.action accept the context keyword argument. That should be doable.

Cheers,
Stefan.

review: Needs Fixing

« Back to merge proposal