Odoo GTK Client (MOVED TO GITHUB)

Code review comment for lp:~openerp-community/openobject-client/zehk_use-of-xdg-open

  1. zehk_use-of-xdg-open
  2. Merge into trunk
Revision history for this message
Naresh(OpenERP) (nch-openerp) wrote :

Hello Zehk,

It seems a good work but I have few doubts... Why do you need to add this extra check for 'posix' and for file types ['xdg-open', 'gnome-open', 'kde-open'] dont we have this check in _findPDFOpener except for the 'kde-open'opener (which can be added there itself) at line 107.

AFAIS the current system do make a check for the applications to be loaded to open the files based on their types or am I missing something ?

Thanks,

review: Needs Information
Reply

« Back to merge proposal