Merge lp:~openerp-community/openobject-addons/trunk-bugfix-membeship into lp:openobject-addons
Proposed by
LudoRA
Status: | Needs review |
---|---|
Proposed branch: | lp:~openerp-community/openobject-addons/trunk-bugfix-membeship |
Merge into: | lp:openobject-addons |
Diff against target: |
12 lines (+1/-1) 1 file modified
membership/membership.py (+1/-1) |
To merge this branch: | bzr merge lp:~openerp-community/openobject-addons/trunk-bugfix-membeship |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Stefan Rijnhart (Opener) (community) | Abstain | ||
OpenERP Core Team | Pending | ||
Review via email: mp+141140@code.launchpad.net |
Description of the change
Just replace membeship_start by membership_start
To post a comment you must log in.
Well this is spellingwise an improvement but judging by the code of the module it has bigger problems than this. None of the three fields that _membership_date can deliver share the same 'multi' argument, which neatly corresponds to the fact that this function only delivers only one field at the time! Personally I would like to see this cleaned up, but I am not the person to ask that of you. Maybe one of the core devs can confirm that they'd be interested in such a proposal?
I'll abstain for now as the spelling error is not visible for users and does not affect the functioning of the code as far as I can see.