Merge lp:~openerp-community/openobject-addons/trunk-bugfix-membeship into lp:openobject-addons

[LudoRA]

Just replace membeship_start by membership_start

[Stefan Rijnhart (Opener) (stefan-opener)]

Well this is spellingwise an improvement but judging by the code of the module it has bigger problems than this. None of the three fields that _membership_date can deliver share the same 'multi' argument, which neatly corresponds to the fact that this function only delivers only one field at the time! Personally I would like to see this cleaned up, but I am not the person to ask that of you. Maybe one of the core devs can confirm that they'd be interested in such a proposal?

I'll abstain for now as the spelling error is not visible for users and does not affect the functioning of the code as far as I can see.

review: Abstain

Unmerged revisions

8470. By LudoRA on 2012-12-21

[FIX] bad membership_start

=== modified file 'membership/membership.py'
--- membership/membership.py	2012-12-17 15:23:03 +0000
+++ membership/membership.py	2012-12-21 22:33:21 +0000
@@ -337,7 +337,7 @@
                     -Invoiced Member: A member whose invoice has been created.
                     -Paying member: A member who has paid the membership fee."""),
         'membership_start': fields.function(
-                    _membership_date, multi = 'membeship_start',
+                    _membership_date, multi = 'membership_start',
                     string = 'Membership Start Date', type = 'date',
                     store = {
                         'account.invoice': (_get_invoice_partner, ['state'], 10),