Code review comment for lp:~openerp-community/openobject-addons/elico-6.0

I never received any feedback from this request. How long should it take
for a normal review?

--
Eric

On Mon, 2011-02-14 at 08:51 +0000, Eric Caudal - www.elico-corp.com
wrote:

> Eric Caudal - www.elico-corp.com has proposed merging lp:~openerp-community/openobject-addons/elico-6.0 into lp:openobject-addons.
>
> Requested reviews:
> OpenERP Core Team (openerp)
>
> For more details, see:
> https://code.launchpad.net/~openerp-community/openobject-addons/elico-6.0/+merge/49599
>
> Main modules are:
> - financial_statements that implements a gross profit report in a flexible reporting setup.
> - year_end_process that implements a more detail year-end process.
>
>
>
> differences between files attachment (review-diff.txt)
>
> === added directory 'elico_account_payment_extension'
> === added file 'elico_account_payment_extension/__init__.py'
> --- elico_account_payment_extension/__init__.py 1970-01-01 00:00:00 +0000
> +++ elico_account_payment_extension/__init__.py 2011-02-14 08:50:44 +0000
> @@ -0,0 +1,23 @@
> +# -*- encoding: utf-8 -*-
> +##############################################################################
> +#
> +# OpenERP, Open Source Management Solution
> +# Copyright (c) 2010-2011 Elico Corp. All Rights Reserved.
> +# Author: Eric CAUDAL <email address hidden>
> +#
> +# This program is free software: you can redistribute it and/or modify
> +# it under the terms of the GNU General Public License as published by
> +# the Free Software Foundation, either version 3 of the License, or
> +# (at your option) any later version.
> +#
> +# This program is distributed in the hope that it will be useful,
> +# but WITHOUT ANY WARRANTY; without even the implied warranty of
> +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
> +# GNU General Public License for more details.
> +#
> +# You should have received a copy of the GNU General Public License
> +# along with this program. If not, see <http://www.gnu.org/licenses/>.
> +#
> +##############################################################################
> +
> +import account_payment_extension_invoice
>
> === added file 'elico_account_payment_extension/__openerp__.py'
> --- elico_account_payment_extension/__openerp__.py 1970-01-01 00:00:00 +0000
> +++ elico_account_payment_extension/__openerp__.py 2011-02-14 08:50:44 +0000
> @@ -0,0 +1,42 @@
> +# -*- coding: utf-8 -*-
> +##############################################################################
> +#
> +# OpenERP, Open Source Management Solution
> +# Copyright (c) 2010-2011 Elico Corp. All Rights Reserved.
> +# Author: Eric CAUDAL <email address hidden>
> +#
> +# This program is free software: you can redistribute it and/or modify
> +# it under the terms of the GNU Affero General Public License as
> +# published by the Free Software Foundation, either version 3 of the
> +# License, or (at your option) any later version.
> +#
> +# This program is distributed in the hope that it will be useful,
> +# but WITHOUT ANY WARRANTY; without even the implied warranty of
> +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
> +# GNU Affero General Public License for more details.
> +#
> +# You should have received a copy of the GNU Affero General Public License
> +# along with this program. If not, see <http://www.gnu.org/licenses/>.
> +#
> +##############################################################################
> +
> +
> +{
> + 'name': 'Make payment information mandatory in invoices',
> + 'version': '1.0',
> + 'category': 'Accounting',
> + 'website' : "www.elico-corp.com",
> + 'description': """
> +Extension to module account in order to:
> +- add mandatory payment type in invoices
> +- add mandatory payment term in invoices""",
> + 'author': 'Eric Caudal (<email address hidden>)',
> + 'depends': ['account_payment_extension'],
> + 'init_xml': [],
> + 'update_xml': ['account_payment_extension_view.xml'],
> + 'demo_xml': [],
> + 'test': [],
> + 'installable': True,
> + 'active': False,
> + 'certificate': '',
> +}
>
> === added directory 'elico_base_contact_extension'
> === added file 'elico_base_contact_extension/__init__.py'
> --- elico_base_contact_extension/__init__.py 1970-01-01 00:00:00 +0000
> +++ elico_base_contact_extension/__init__.py 2011-02-14 08:50:44 +0000
> @@ -0,0 +1,23 @@
> +# -*- encoding: utf-8 -*-
> +##############################################################################
> +#
> +# OpenERP, Open Source Management Solution
> +# Copyright (c) 2010-2011 Elico Corp. All Rights Reserved.
> +# Author: Eric CAUDAL <email address hidden>
> +# $Id$
> +#
> +# This program is free software: you can redistribute it and/or modify
> +# it under the terms of the GNU General Public License as published by
> +# the Free Software Foundation, either version 3 of the License, or
> +# (at your option) any later version.
> +#
> +# This program is distributed in the hope that it will be useful,
> +# but WITHOUT ANY WARRANTY; without even the implied warranty of
> +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
> +# GNU General Public License for more details.
> +#
> +# You should have received a copy of the GNU General Public License
> +# along with this program. If not, see <http://www.gnu.org/licenses/>.
> +#
> +##############################################################################
> +
>
> === added file 'elico_base_contact_extension/__openerp__.py'
> --- elico_base_contact_extension/__openerp__.py 1970-01-01 00:00:00 +0000
> +++ elico_base_contact_extension/__openerp__.py 2011-02-14 08:50:44 +0000
> @@ -0,0 +1,40 @@
> +# -*- coding: utf-8 -*-
> +##############################################################################
> +#
> +# OpenERP, Open Source Management Solution
> +# Copyright (c) 2010-2011 Elico Corp. All Rights Reserved.
> +# Author: Eric CAUDAL <email address hidden>
> +#
> +# This program is free software: you can redistribute it and/or modify
> +# it under the terms of the GNU Affero General Public License as
> +# published by the Free Software Foundation, either version 3 of the
> +# License, or (at your option) any later version.
> +#
> +# This program is distributed in the hope that it will be useful,
> +# but WITHOUT ANY WARRANTY; without even the implied warranty of
> +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
> +# GNU Affero General Public License for more details.
> +#
> +# You should have received a copy of the GNU Affero General Public License
> +# along with this program. If not, see <http://www.gnu.org/licenses/>.
> +#
> +##############################################################################
> +
> +
> +{
> + 'name': 'Street information added in base contact tree',
> + 'version': '1.0',
> + 'category': 'Generic Modules/Base',
> + 'description': """
> +Extension to module base_contact to add field addr1 (street details) in base contact form """,
> + 'author': 'Eric Caudal (<email address hidden>)',
> + 'website': 'http://www.elico-corp.com',
> + 'depends': ['base_contact'],
> + 'init_xml': [],
> + 'update_xml': ['base_contact_view.xml'],
> + 'demo_xml': [],
> + 'test': [],
> + 'installable': True,
> + 'active': False,
> + 'certificate': '',
> +}
>
> _______________________________________________
> Mailing list: https://launchpad.net/~openerp-community
> Post to : <email address hidden>
> Unsubscribe : https://launchpad.net/~openerp-community
> More help : https://help.launchpad.net/ListHelp