Code review comment for lp:~openerp-community/openobject-addons/7.0-587621-opw-orphan-voucher

Hello Niels,

Well, this does not seem to be an issue that needs an OPW cover to get in to stable, rather it seems an improvement. Secondly, according to the current stable source the related vouchers are set to cancelled state when you cancel the bank statement and later if you confirm the bank statement again the same voucher will be in posted state. Which is so far good.

Now comes your case(@Niels) for which you have proposed a merge proposal https://code.launchpad.net/~openerp-community/openobject-addons/7.0-587621-opw-orphan-voucher/+merge/154932 where in you unlink the isolated vouchers that are result of changing the original amount on the bank statement line. But here if you look closely as soon as you change the original amount on the bank statement line the button on the line will turn *red* if the balance does not match that means you need to take care you are reconciling it with the correct amount. To Fix this you need to click on the button to and change the *Allocation* value to the actual value you want to reconcile. As soon as you correct that you see the button turns *Green* means everything is correctly setup and now you can proceed with reconciliation. In this case the previous voucher will be in cancelled state and a new entry will be created and reconciled(posted).

Keeping the history of vouchers (altered ones) seems good. instead of setting them to draft and later unlinking them.

However, we its still open to be discussed.

Thanks,