Merge lp:~openerp-community-reviewer/sale-wkfl/move_sale_exception_module_from_e-commerce-addons-jge into lp:~sale-core-editors/sale-wkfl/7.0

[Joël Grand-Guillaume @ camptocamp]

[MOVE] Move here the sale_exceptions module from the lp:e-commerce-addons

Hi,

I suggest to move the sale_exceptions module from e-commerce-addons to here because it really concerns the sales workflow in a more generic way than just the e-commerce context.

I put the branch under the reviewer team so feel free to fix stuff if you'd like.

WARNING: Merge this proposal when this one is done : https://code.launchpad.net/~openerp-community-reviewer/e-commerce-addons/move_sale_exception_to_sale_wkfl_branches-jge/+merge/193570

Regards,

Joël

[Pedro Manuel Baeza (pedro.baeza)]

As your reasoning on community list, I approve it blindly.

Regards.

[Sébastien BEAU - http://www.akretion.com (sebastien.beau)]

Hi, I am working on the split of sale_exception in two module "sale_exception" and "exception_rule". The aim is to have the exception on different object like purchase_order, stock_picking, invoice ... (already implemented on purchase_order and soon on picking).
If we put the module sale_exception here where should I put the module "exception_rule" and "purchase_exception" (and later stock_picking_exception)?

I see two solution possible
- Putting exception_rule in "server-env-tools" and than all implementation in sale-wkfl, purchase-wkfl...
- Creating a project "workflow-exception" and put all exception module here

What do you prefers?

[Pedro Manuel Baeza (pedro.baeza)]

Hi, Sébastien, is there too much logic on exception_rule so that it is mandatory to split it in one module?, or it can be easily repeated in consequent other modules "purchase_exception", "stock_exception", etc?

Regards.

[Joël Grand-Guillaume @ camptocamp (jgrandguillaume-c2c)]

Hi,

+1 for Pedro. Having such a general module doesn't seems mandatory. The exception can IMO define in every module.

Moreover, the sale_exception module was already there like this. So I just move it. We can't assume doing both in one. Your suggestion may break back-compatibility so... My suggestion: move on to have it in the right project/branches, then when you'll be ready, make your MP so we'll have the opportunity to discuss that with something concrete !

What do you think ?

++

Joël

[Sébastien BEAU - http://www.akretion.com (sebastien.beau)]

After my split I have around 140 ligne of python in exception_rule and around 40 in sale_exception so I really think it's worth to split it because we will avoid to duplicate the 140 ligne in every module for nothing, it's not a lot but it's always better to no duplicate the code (on improvement improve all module). Moreover we use the same pop-up wizard in sale_exception and purchase_exception so it the same interface for the end user.

Here is my work : http://bazaar.launchpad.net/~sebastien.beau/e-commerce-addons/e-commerce-addons-split-sale-exception/view/head:/sale_exceptions/sale.py
(not ready to be merge yet, I have to be sure that I do not miss any improvement done by guewen here https://code.launchpad.net/~extra-addons-commiter/e-commerce-addons/7.0)

[Sébastien BEAU - http://www.akretion.com (sebastien.beau)]

Sorry I made a mistake around 180 line in the generic module

[Joël Grand-Guillaume @ camptocamp (jgrandguillaume-c2c)]

Hi Sébastien,

Your work looks great. Can you please make another MP once this one is done with your work ? This we move forward on this one.

@Pedro : Would you add your review here please ?

Regards,

[Guewen Baconnier @ Camptocamp (gbaconnier-c2c)]

I approve for the move

review: Approve

[lp:~openerp-community-reviewer/sale-wkfl/move_sale_exception_module_from_e-commerce-addons-jge]

46. By Nicolas Bessi - Camptocamp on 2013-11-15

[PEP8] and community conventions

47. By Nicolas Bessi - Camptocamp on 2013-11-15

[PEP8]

48. By Nicolas Bessi - Camptocamp on 2013-11-15

[PEP8] + removing class instantiation

[Nicolas Bessi - Camptocamp (nbessi-c2c-deactivatedaccount)]

LGTM

I also committed PEP8 and community convention fixes.

Moving the module is OK.

review: Approve (no test, code review)

[lp:~openerp-community-reviewer/sale-wkfl/move_sale_exception_module_from_e-commerce-addons-jge]

49. By Nicolas Bessi - Camptocamp on 2013-11-15

[FIX] licence

50. By Nicolas Bessi - Camptocamp on 2013-11-15

[MRG] migration of sale_exceptions from original branch

[Nicolas Bessi - Camptocamp (nbessi-c2c-deactivatedaccount)]

Hello,

I have merge back migration/fixes recently commited in lp:e-commerce-addons

=== added directory 'sale_exceptions'
=== added file 'sale_exceptions/__init__.py'
--- sale_exceptions/__init__.py	1970-01-01 00:00:00 +0000
+++ sale_exceptions/__init__.py	2013-11-15 12:55:43 +0000
@@ -0,0 +1,26 @@
+# -*- coding: utf-8 -*-
+##############################################################################
+#
+#    OpenERP, Open Source Management Solution
+#    Copyright (C) 2011 Akretion LTDA.
+#    authors: Raphaël Valyi, Renato Lima
+#    Copyright (C) 2010-2012 Akretion Sébastien BEAU <[e-mail]>
+#    Copyright (C) 2012 Camptocamp SA (Guewen Baconnier)
+#
+#    This program is free software: you can redistribute it and/or modify
+#    it under the terms of the GNU Affero General Public License as
+#    published by the Free Software Foundation, either version 3 of the
+#    License, or (at your option) any later version.
+#
+#    This program is distributed in the hope that it will be useful,
+#    but WITHOUT ANY WARRANTY; without even the implied warranty of
+#    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+#    GNU Affero General Public License for more details.
+#
+#    You should have received a copy of the GNU Affero General Public License
+#    along with this program.  If not, see <http://www.gnu.org/licenses/>.
+#
+##############################################################################
+
+from . import sale
+from . import wizard
 
=== added file 'sale_exceptions/__openerp__.py'
--- sale_exceptions/__openerp__.py	1970-01-01 00:00:00 +0000
+++ sale_exceptions/__openerp__.py	2013-11-15 12:55:43 +0000
@@ -0,0 +1,46 @@
+# -*- coding: utf-8 -*-
+##############################################################################
+#
+#    OpenERP, Open Source Management Solution
+#    Copyright (C) 2011 Akretion LTDA.
+#    authors: Raphaël Valyi, Renato Lima
+#    Copyright (C) 2010-2012 Akretion Sébastien BEAU <[e-mail]>
+#    Copyright (C) 2012 Camptocamp SA (Guewen Baconnier)
+#
+#    This program is free software: you can redistribute it and/or modify
+#    it under the terms of the GNU Affero General Public License as
+#    published by the Free Software Foundation, either version 3 of the
+#    License, or (at your option) any later version.
+#
+#    This program is distributed in the hope that it will be useful,
+#    but WITHOUT ANY WARRANTY; without even the implied warranty of
+#    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+#    GNU Affero General Public License for more details.
+#
+#    You should have received a copy of the GNU Affero General Public License
+#    along with this program.  If not, see <http://www.gnu.org/licenses/>.
+#
+##############################################################################
+{'name': 'Sale Exceptions',
+ 'version': '0.1',
+ 'category': 'Generic Modules/Sale',
+ 'description': """
+This module allows you attach several customizable exceptions to your sale order
+ in a way that you can filter orders by exceptions type and fix them.
+
+This is especially useful in an order importation scenario such as with
+the base_sale_multi_channels module, because it's likely a few orders have errors
+when you import them (like product not found in OpenERP, wrong line format etc...)
+""",
+ 'author': 'Akretion',
+ 'website': 'http://www.akretion.com',
+ 'depends': ['sale'],
+ 'init_xml': ['settings/sale.exception.csv'],
+ 'update_xml': ['sale_workflow.xml',
+                'sale_view.xml',
+                'sale_exceptions_data.xml',
+                'wizard/sale_exception_confirm_view.xml',
+                'security/ir.model.access.csv'],
+ 'demo_xml': [],
+ 'installable': True,
+ }
 
=== added directory 'sale_exceptions/i18n'
=== added file 'sale_exceptions/i18n/fr.po'
--- sale_exceptions/i18n/fr.po	1970-01-01 00:00:00 +0000
+++ sale_exceptions/i18n/fr.po	2013-11-15 12:55:43 +0000
@@ -0,0 +1,177 @@
+# Translation of OpenERP Server.
+# This file contains the translation of the following modules:
+#	* sale_exceptions
+#
+msgid ""
+msgstr ""
+"Project-Id-Version: OpenERP Server 7.0\n"
+"Report-Msgid-Bugs-To: \n"
+"POT-Creation-Date: 2013-05-02 06:57+0000\n"
+"PO-Revision-Date: 2013-05-02 06:57+0000\n"
+"Last-Translator: <>\n"
+"Language-Team: \n"
+"MIME-Version: 1.0\n"
+"Content-Type: text/plain; charset=UTF-8\n"
+"Content-Transfer-Encoding: \n"
+"Plural-Forms: \n"
+
+#. module: sale_exceptions
+#: model:ir.model,name:sale_exceptions.model_sale_exception_confirm
+msgid "sale.exception.confirm"
+msgstr ""
+
+#. module: sale_exceptions
+#: selection:sale.exception,model:0
+msgid "Sale Order Line"
+msgstr "Ligne de commande"
+
+#. module: sale_exceptions
+#: field:sale.exception,model:0
+msgid "Apply on"
+msgstr "Appliquer sur"
+
+#. module: sale_exceptions
+#: model:sale.exception,name:sale_exceptions.excep_no_stock
+msgid "Not Enough Virtual Stock"
+msgstr "Pas assez de quantité de stock prévue"
+
+#. module: sale_exceptions
+#: field:sale.exception,description:0
+msgid "Description"
+msgstr "Description"
+
+#. module: sale_exceptions
+#: help:sale.exception,sequence:0
+msgid "Gives the sequence order when applying the test"
+msgstr "Définit l'ordre d'application des contrôles"
+
+#. module: sale_exceptions
+#: view:sale.exception.confirm:0
+msgid "Sale Exceptions On Sale Order"
+msgstr "Restrictions sur la commande"
+
+#. module: sale_exceptions
+#: field:sale.exception.confirm,exception_ids:0
+msgid "Exceptions to resolve"
+msgstr "Restrictions à résoudre"
+
+#. module: sale_exceptions
+#: view:sale.exception.confirm:0
+msgid "_Ok"
+msgstr "_Ok"
+
+#. module: sale_exceptions
+#: view:sale.exception:0
+#: view:sale.exception.confirm:0
+msgid "Sale Exception"
+msgstr "Restriction de vente"
+
+#. module: sale_exceptions
+#: view:sale.order:0
+msgid "TO FIX"
+msgstr "A CORRIGER"
+
+#. module: sale_exceptions
+#: help:sale.exception,code:0
+msgid "Python code executed to check if the exception apply or not. The code must apply block = True to apply the exception."
+msgstr "Code Python exécuté pour déterminer si la restriction s'applique. The bloc de code doit retourner block = True pour appliquer la restriction."
+
+#. module: sale_exceptions
+#: view:sale.order:0
+msgid "Exception"
+msgstr "Restriction"
+
+#. module: sale_exceptions
+#: view:sale.order:0
+msgid "Error:"
+msgstr "Erreur :"
+
+#. module: sale_exceptions
+#: selection:sale.exception,model:0
+msgid "Sale Order"
+msgstr "Bon de commande"
+
+#. module: sale_exceptions
+#: field:sale.exception.confirm,sale_id:0
+msgid "Sale"
+msgstr "Commande"
+
+#. module: sale_exceptions
+#: field:sale.exception,active:0
+msgid "Active"
+msgstr "Actif"
+
+#. module: sale_exceptions
+#: field:sale.exception,name:0
+msgid "Exception Name"
+msgstr "Nom de la restriction"
+
+#. module: sale_exceptions
+#: field:sale.order,exceptions_ids:0
+msgid "Exceptions"
+msgstr "Restrictions"
+
+#. module: sale_exceptions
+#: model:ir.actions.act_window,name:sale_exceptions.action_sale_exception_confirm
+#: model:ir.model,name:sale_exceptions.model_sale_exception
+#: view:sale.exception.confirm:0
+msgid "Sale Exceptions"
+msgstr "Restrictions de vente"
+
+#. module: sale_exceptions
+#: model:ir.actions.act_window,name:sale_exceptions.action_sale_test_tree
+#: model:ir.ui.menu,name:sale_exceptions.menu_sale_test
+msgid "Exception Rules"
+msgstr "Règles de restriction"
+
+#. module: sale_exceptions
+#: model:ir.model,name:sale_exceptions.model_sale_order
+msgid "Sales Order"
+msgstr "Bon de commande"
+
+#. module: sale_exceptions
+#: field:sale.exception,sequence:0
+msgid "Sequence"
+msgstr "Séquence"
+
+#. module: sale_exceptions
+#: field:sale.exception,code:0
+msgid "Python Code"
+msgstr "Code Python"
+
+#. module: sale_exceptions
+#: view:sale.order:0
+msgid "Sales"
+msgstr "Bons de commande"
+
+#. module: sale_exceptions
+#: model:sale.exception,name:sale_exceptions.excep_no_zip
+msgid "No ZIP code on destination"
+msgstr "Code postal manquant sur la destination"
+
+#. module: sale_exceptions
+#: view:sale.exception:0
+msgid "Sale Exception Setup"
+msgstr "Configuration des restrictions de vente"
+
+#. module: sale_exceptions
+#: view:sale.exception:0
+msgid "Affected Sales Orders"
+msgstr "Bons de commande affectés"
+
+#. module: sale_exceptions
+#: field:sale.exception,sale_order_ids:0
+msgid "Sale Orders"
+msgstr "Bons de commande"
+
+#. module: sale_exceptions
+#: field:sale.exception.confirm,ignore:0
+#: field:sale.order,ignore_exceptions:0
+msgid "Ignore Exceptions"
+msgstr "Ignorer la restriction"
+
+#. module: sale_exceptions
+#: field:sale.order,main_exception_id:0
+msgid "Main Exception"
+msgstr "Restriction principale"
+
 
=== added file 'sale_exceptions/i18n/sale_exceptions.pot'
--- sale_exceptions/i18n/sale_exceptions.pot	1970-01-01 00:00:00 +0000
+++ sale_exceptions/i18n/sale_exceptions.pot	2013-11-15 12:55:43 +0000
@@ -0,0 +1,177 @@
+# Translation of OpenERP Server.
+# This file contains the translation of the following modules:
+#	* sale_exceptions
+#
+msgid ""
+msgstr ""
+"Project-Id-Version: OpenERP Server 7.0\n"
+"Report-Msgid-Bugs-To: \n"
+"POT-Creation-Date: 2013-05-02 06:57+0000\n"
+"PO-Revision-Date: 2013-05-02 06:57+0000\n"
+"Last-Translator: <>\n"
+"Language-Team: \n"
+"MIME-Version: 1.0\n"
+"Content-Type: text/plain; charset=UTF-8\n"
+"Content-Transfer-Encoding: \n"
+"Plural-Forms: \n"
+
+#. module: sale_exceptions
+#: model:ir.model,name:sale_exceptions.model_sale_exception_confirm
+msgid "sale.exception.confirm"
+msgstr ""
+
+#. module: sale_exceptions
+#: selection:sale.exception,model:0
+msgid "Sale Order Line"
+msgstr ""
+
+#. module: sale_exceptions
+#: field:sale.exception,model:0
+msgid "Apply on"
+msgstr ""
+
+#. module: sale_exceptions
+#: model:sale.exception,name:sale_exceptions.excep_no_stock
+msgid "Not Enough Virtual Stock"
+msgstr ""
+
+#. module: sale_exceptions
+#: field:sale.exception,description:0
+msgid "Description"
+msgstr ""
+
+#. module: sale_exceptions
+#: help:sale.exception,sequence:0
+msgid "Gives the sequence order when applying the test"
+msgstr ""
+
+#. module: sale_exceptions
+#: view:sale.exception.confirm:0
+msgid "Sale Exceptions On Sale Order"
+msgstr ""
+
+#. module: sale_exceptions
+#: field:sale.exception.confirm,exception_ids:0
+msgid "Exceptions to resolve"
+msgstr ""
+
+#. module: sale_exceptions
+#: view:sale.exception.confirm:0
+msgid "_Ok"
+msgstr ""
+
+#. module: sale_exceptions
+#: view:sale.exception:0
+#: view:sale.exception.confirm:0
+msgid "Sale Exception"
+msgstr ""
+
+#. module: sale_exceptions
+#: view:sale.order:0
+msgid "TO FIX"
+msgstr ""
+
+#. module: sale_exceptions
+#: help:sale.exception,code:0
+msgid "Python code executed to check if the exception apply or not. The code must apply block = True to apply the exception."
+msgstr ""
+
+#. module: sale_exceptions
+#: view:sale.order:0
+msgid "Exception"
+msgstr ""
+
+#. module: sale_exceptions
+#: view:sale.order:0
+msgid "Error:"
+msgstr ""
+
+#. module: sale_exceptions
+#: selection:sale.exception,model:0
+msgid "Sale Order"
+msgstr ""
+
+#. module: sale_exceptions
+#: field:sale.exception.confirm,sale_id:0
+msgid "Sale"
+msgstr ""
+
+#. module: sale_exceptions
+#: field:sale.exception,active:0
+msgid "Active"
+msgstr ""
+
+#. module: sale_exceptions
+#: field:sale.exception,name:0
+msgid "Exception Name"
+msgstr ""
+
+#. module: sale_exceptions
+#: field:sale.order,exceptions_ids:0
+msgid "Exceptions"
+msgstr ""
+
+#. module: sale_exceptions
+#: model:ir.actions.act_window,name:sale_exceptions.action_sale_exception_confirm
+#: model:ir.model,name:sale_exceptions.model_sale_exception
+#: view:sale.exception.confirm:0
+msgid "Sale Exceptions"
+msgstr ""
+
+#. module: sale_exceptions
+#: model:ir.actions.act_window,name:sale_exceptions.action_sale_test_tree
+#: model:ir.ui.menu,name:sale_exceptions.menu_sale_test
+msgid "Exception Rules"
+msgstr ""
+
+#. module: sale_exceptions
+#: model:ir.model,name:sale_exceptions.model_sale_order
+msgid "Sales Order"
+msgstr ""
+
+#. module: sale_exceptions
+#: field:sale.exception,sequence:0
+msgid "Sequence"
+msgstr ""
+
+#. module: sale_exceptions
+#: field:sale.exception,code:0
+msgid "Python Code"
+msgstr ""
+
+#. module: sale_exceptions
+#: view:sale.order:0
+msgid "Sales"
+msgstr ""
+
+#. module: sale_exceptions
+#: model:sale.exception,name:sale_exceptions.excep_no_zip
+msgid "No ZIP code on destination"
+msgstr ""
+
+#. module: sale_exceptions
+#: view:sale.exception:0
+msgid "Sale Exception Setup"
+msgstr ""
+
+#. module: sale_exceptions
+#: view:sale.exception:0
+msgid "Affected Sales Orders"
+msgstr ""
+
+#. module: sale_exceptions
+#: field:sale.exception,sale_order_ids:0
+msgid "Sale Orders"
+msgstr ""
+
+#. module: sale_exceptions
+#: field:sale.exception.confirm,ignore:0
+#: field:sale.order,ignore_exceptions:0
+msgid "Ignore Exceptions"
+msgstr ""
+
+#. module: sale_exceptions
+#: field:sale.order,main_exception_id:0
+msgid "Main Exception"
+msgstr ""
+
 
=== added file 'sale_exceptions/sale.py'
--- sale_exceptions/sale.py	1970-01-01 00:00:00 +0000
+++ sale_exceptions/sale.py	2013-11-15 12:55:43 +0000
@@ -0,0 +1,236 @@
+# -*- coding: utf-8 -*-
+##############################################################################
+#
+#    OpenERP, Open Source Management Solution
+#    Copyright (C) 2011 Akretion LTDA.
+#    Copyright (C) 2010-2012 Akretion Sébastien BEAU <[e-mail]>
+#    Copyright (C) 2012 Camptocamp SA (Guewen Baconnier)
+#
+#    This program is free software: you can redistribute it and/or modify
+#    it under the terms of the GNU Affero General Public License as
+#    published by the Free Software Foundation, either version 3 of the
+#    License, or (at your option) any later version.
+#
+#    This program is distributed in the hope that it will be useful,
+#    but WITHOUT ANY WARRANTY; without even the implied warranty of
+#    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+#    GNU Affero General Public License for more details.
+#
+#    You should have received a copy of the GNU Affero General Public License
+#    along with this program.  If not, see <http://www.gnu.org/licenses/>.
+#
+##############################################################################
+
+import time
+
+from openerp.osv import orm, fields
+from openerp.tools.safe_eval import safe_eval
+from openerp.tools.translate import _
+
+
+class sale_exception(orm.Model):
+    _name = "sale.exception"
+    _description = "Sale Exceptions"
+    _order = "active desc, sequence asc"
+    _columns = {
+        'name': fields.char('Exception Name', required=True, translate=True),
+        'description': fields.text('Description', translate=True),
+        'sequence': fields.integer(
+            'Sequence',
+            help="Gives the sequence order when applying the test"),
+        'model': fields.selection([('sale.order', 'Sale Order'),
+                                   ('sale.order.line', 'Sale Order Line')],
+                                  string='Apply on', required=True),
+        'active': fields.boolean('Active'),
+        'code': fields.text(
+            'Python Code',
+            help="Python code executed to check if the exception apply or not. "
+                 "The code must apply block = True to apply the exception."),
+        'sale_order_ids': fields.many2many(
+            'sale.order',
+            'sale_order_exception_rel', 'exception_id', 'sale_order_id',
+            string='Sale Orders',
+            readonly=True),
+    }
+
+    _defaults = {
+        'code': """# Python code. Use failed = True to block the sale order.
+# You can use the following variables :
+#  - self: ORM model of the record which is checked
+#  - order or line: browse_record of the sale order or sale order line
+#  - object: same as order or line, browse_record of the sale order or sale order line
+#  - pool: ORM model pool (i.e. self.pool)
+#  - time: Python time module
+#  - cr: database cursor
+#  - uid: current user id
+#  - context: current context
+"""
+    }
+
+
+class sale_order(orm.Model):
+    _inherit = "sale.order"
+
+    _order = 'main_exception_id asc, date_order desc, name desc'
+
+    def _get_main_error(self, cr, uid, ids, name, args, context=None):
+        res = {}
+        for sale_order in self.browse(cr, uid, ids, context=context):
+            if sale_order.state == 'draft' and sale_order.exceptions_ids:
+                res[sale_order.id] = sale_order.exceptions_ids[0].id
+            else:
+                res[sale_order.id] = False
+        return res
+
+    _columns = {
+        'main_exception_id': fields.function(
+            _get_main_error,
+            type='many2one',
+            relation="sale.exception",
+            string='Main Exception',
+            store={
+                'sale.order': (lambda self, cr, uid, ids, c=None: ids,
+                               ['exceptions_ids', 'state'], 10),
+            }),
+        'exceptions_ids': fields.many2many(
+            'sale.exception',
+            'sale_order_exception_rel', 'sale_order_id', 'exception_id',
+            string='Exceptions'),
+        'ignore_exceptions': fields.boolean('Ignore Exceptions'),
+    }
+
+    def test_all_draft_orders(self, cr, uid, context=None):
+        ids = self.search(cr, uid, [('state', '=', 'draft')], context=context)
+        self.test_exceptions(cr, uid, ids, context=context)
+        return True
+
+    def _popup_exceptions(self, cr, uid, order_id, context=None):
+        if context is None:
+            context = {}
+        model_data_obj = self.pool.get('ir.model.data')
+        list_obj = self.pool.get('sale.exception.confirm')
+        ctx = context.copy()
+        ctx.update({'active_id': order_id,
+                    'active_ids': [order_id]})
+        list_id = list_obj.create(cr, uid, {}, context=ctx)
+        view_id = model_data_obj.get_object_reference(
+            cr, uid, 'sale_exceptions', 'view_sale_exception_confirm')[1]
+        action = {
+            'name': _("Blocked in draft due to exceptions"),
+            'type': 'ir.actions.act_window',
+            'view_type': 'form',
+            'view_mode': 'form',
+            'res_model': 'sale.exception.confirm',
+            'view_id': [view_id],
+            'target': 'new',
+            'nodestroy': True,
+            'res_id': list_id,
+        }
+        return action
+
+    def action_button_confirm(self, cr, uid, ids, context=None):
+        exception_ids = self.detect_exceptions(cr, uid, ids, context=context)
+        if exception_ids:
+            return self._popup_exceptions(cr, uid, ids[0],  context=context)
+        else:
+            return super(sale_order, self).action_button_confirm(cr, uid, ids,
+                                                                 context=context)
+
+    def test_exceptions(self, cr, uid, ids, context=None):
+        """
+        Condition method for the workflow from draft to confirm
+        """
+        exception_ids = self.detect_exceptions(cr, uid, ids, context=context)
+        if exception_ids:
+            return False
+        return True
+
+    def detect_exceptions(self, cr, uid, ids, context=None):
+        exception_obj = self.pool.get('sale.exception')
+        order_exception_ids = exception_obj.search(
+            cr, uid,
+            [('model', '=', 'sale.order')],
+            context=context)
+        line_exception_ids = exception_obj.search(
+            cr, uid,
+            [('model', '=', 'sale.order.line')],
+            context=context)
+
+        order_exceptions = exception_obj.browse(cr, uid, order_exception_ids,
+                                                context=context)
+        line_exceptions = exception_obj.browse(cr, uid, line_exception_ids,
+                                               context=context)
+
+        exception_ids = False
+        for order in self.browse(cr, uid, ids, context=context):
+            if order.ignore_exceptions:
+                continue
+            exception_ids = self._detect_exceptions(cr, uid,
+                                                    order,
+                                                    order_exceptions,
+                                                    line_exceptions,
+                                                    context=context)
+
+            self.write(cr, uid, [order.id],
+                       {'exceptions_ids': [(6, 0, exception_ids)]},
+                       context=context)
+        return exception_ids
+
+    def _exception_rule_eval_context(self, cr, uid, obj_name, obj, context=None):
+        if context is None:
+            context = {}
+
+        user = self.pool.get('res.users').browse(cr, uid, uid, context=context)
+        return {obj_name: obj,
+                'self': self.pool.get(obj._name),
+                'object': obj,
+                'obj': obj,
+                'pool': self.pool,
+                'cr': cr,
+                'uid': uid,
+                'user': user,
+                'time': time,
+                # copy context to prevent side-effects of eval
+                'context': context.copy()}
+
+    def _rule_eval(self, cr, uid, rule, obj_name, obj, context):
+        expr = rule.code
+        space = self._exception_rule_eval_context(cr, uid, obj_name, obj,
+                                                  context=context)
+        try:
+            safe_eval(expr,
+                      space,
+                      mode='exec',
+                      nocopy=True)  # nocopy allows to return 'result'
+        except Exception, e:
+            raise orm.except_orm(
+                _('Error'),
+                _('Error when evaluating the sale exception '
+                  'rule:\n %s \n(%s)') % (rule.name, e))
+        return space.get('failed', False)
+
+    def _detect_exceptions(self, cr, uid, order, order_exceptions,
+                           line_exceptions, context=None):
+        exception_ids = []
+        for rule in order_exceptions:
+            if self._rule_eval(cr, uid, rule, 'order', order, context):
+                exception_ids.append(rule.id)
+
+        for order_line in order.order_line:
+            for rule in line_exceptions:
+                if rule.id in exception_ids:
+                    # we do not matter if the exception as already been
+                    # found for an order line of this order
+                    continue
+                if self._rule_eval(cr, uid, rule, 'line', order_line, context):
+                    exception_ids.append(rule.id)
+
+        return exception_ids
+
+    def copy(self, cr, uid, id, default=None, context=None):
+        if default is None:
+            default = {}
+        default.update({
+            'ignore_exceptions': False,
+        })
+        return super(sale_order, self).copy(cr, uid, id, default=default, context=context)
 
=== added file 'sale_exceptions/sale_exceptions_data.xml'
--- sale_exceptions/sale_exceptions_data.xml	1970-01-01 00:00:00 +0000
+++ sale_exceptions/sale_exceptions_data.xml	2013-11-15 12:55:43 +0000
@@ -0,0 +1,19 @@
+<?xml version="1.0" encoding="utf-8"?>
+<openerp>
+    <data noupdate="1">
+
+        <record forcecreate="True" id="ir_cron_test_orders" model="ir.cron">
+            <field name="name">Test Draft Orders</field>
+            <field eval="False" name="active"/>
+            <field name="user_id" ref="base.user_root"/>
+            <field name="interval_number">20</field>
+            <field name="interval_type">minutes</field>
+            <field name="numbercall">-1</field>
+            <field eval="False" name="doall"/>
+            <field eval="'sale.order'" name="model"/>
+            <field eval="'test_all_draft_orders'" name="function"/>
+            <field eval="'()'" name="args"/>
+        </record>
+    
+    </data>
+</openerp>
 
=== added file 'sale_exceptions/sale_view.xml'
--- sale_exceptions/sale_view.xml	1970-01-01 00:00:00 +0000
+++ sale_exceptions/sale_view.xml	2013-11-15 12:55:43 +0000
@@ -0,0 +1,102 @@
+<?xml version="1.0" ?>
+<openerp>
+    <data>
+
+        <record id="view_sale_exception_tree" model="ir.ui.view">
+            <field name="name">sale.exception.tree</field>
+            <field name="model">sale.exception</field>
+            <field name="arch" type="xml">
+                <tree string="Sale Exception">
+                    <field name="active"/>
+                    <field name="name"/>
+                    <field name="description"/>
+                    <field name="model"/>
+                    <field name="sequence"/>
+                </tree>
+            </field>
+        </record>
+
+        <record id="view_sale_exception_form" model="ir.ui.view">
+            <field name="name">sale.exception.form</field>
+            <field name="model">sale.exception</field>
+            <field name="arch" type="xml">
+                <form string="Sale Exception Setup">
+                    <group colspan="4" col="2">
+                        <field name="name"/>
+                        <field name="description"/>
+                    </group>
+                    <group col="4" colspan="4" groups="base.group_sale_manager">
+                        <field name="active"/>
+                        <field name="sequence"/>
+                        <group colspan="4" col="2" groups="base.group_system">
+                            <field name="model"/>
+                            <field name="code"/>
+                        </group>
+                    </group>
+                    <group colspan="4" col="2">
+                        <separator string="Affected Sales Orders"/>
+                        <newline/>
+                        <field name="sale_order_ids" nolabel="1" domain="[('state', '=', 'draft')]"/>
+                    </group>
+                </form>
+            </field>
+        </record>
+
+        <record id="action_sale_test_tree" model="ir.actions.act_window">
+                  <field name="name">Exception Rules</field>
+                  <field name="res_model">sale.exception</field>
+                  <field name="view_type">form</field>
+                  <field name="view_mode">tree,form</field>
+                  <field name="view_id" ref="view_sale_exception_tree"/>
+                  <field name="context">{'active_test': False}</field>
+              </record>
+
+        <menuitem action="action_sale_test_tree" id="menu_sale_test" parent="base.menu_sale_config_sales" />
+
+
+        <record id="view_order_form" model="ir.ui.view">
+            <field name="name">sale_exceptions.view_order_form</field>
+            <field name="model">sale.order</field>
+            <field name="inherit_id" ref="sale.view_order_form"/>
+            <field name="arch" type="xml">
+                <field name="name" position="after">
+                    <group>
+                    <field name="main_exception_id" options='{"no_open": True}'
+                           class="oe_inline" string="Error:"
+                           attrs="{'invisible':[('main_exception_id','=', False)]}"/>
+                    </group>
+                </field>
+                <xpath expr="//page[@string='Other Information']/group"
+                        position="inside">
+                    <group name="exception" colspan="2" col="2">
+                        <separator string="Exception" colspan="2"/>
+                        <field name="exceptions_ids" colspan="2" nolabel="1"/>
+                    </group>
+                </xpath>
+            </field>
+        </record>
+
+        <record id="view_order_tree" model="ir.ui.view">
+            <field name="name">sale_exceptions.view_order_tree</field>
+            <field name="model">sale.order</field>
+            <field name="inherit_id" ref="sale.view_order_tree"/>
+            <field name="arch" type="xml">
+                <field name="state" position="after">
+                    <field name="main_exception_id"/>
+                </field>
+            </field>
+        </record>
+
+        <record id="view_sales_order_filter" model="ir.ui.view">
+            <field name="name">sale_exceptions.view_sales_order_filter</field>
+            <field name="model">sale.order</field>
+            <field name="inherit_id" ref="sale.view_sales_order_filter" />
+            <field name="arch" type="xml">
+                <filter name="sales" position="after">
+                    <separator orientation="vertical"/>
+                    <filter icon="terp-emblem-important" name="tofix" string="Blocked in draft" domain="[('main_exception_id','!=',False)]"/>
+                </filter>
+            </field>
+        </record>
+    </data>
+</openerp>
 
=== added file 'sale_exceptions/sale_workflow.xml'
--- sale_exceptions/sale_workflow.xml	1970-01-01 00:00:00 +0000
+++ sale_exceptions/sale_workflow.xml	2013-11-15 12:55:43 +0000
@@ -0,0 +1,9 @@
+<?xml version="1.0" encoding="utf-8"?>
+<openerp>
+    <data>
+        <record id="sale.trans_draft_router" model="workflow.transition">
+            <field name="signal">order_confirm</field>
+            <field name="condition">test_exceptions()</field>
+        </record>
+    </data>
+</openerp>
 
=== added directory 'sale_exceptions/security'
=== added file 'sale_exceptions/security/ir.model.access.csv'
--- sale_exceptions/security/ir.model.access.csv	1970-01-01 00:00:00 +0000
+++ sale_exceptions/security/ir.model.access.csv	2013-11-15 12:55:43 +0000
@@ -0,0 +1,3 @@
+"id","name","model_id:id","group_id:id","perm_read","perm_write","perm_create","perm_unlink"
+"access_sale_exception","sale.exception","model_sale_exception","base.group_user",1,0,0,0
+"access_sale_exception_manager","sale.exception","model_sale_exception","base.group_sale_manager",1,1,1,1
 
=== added directory 'sale_exceptions/settings'
=== added file 'sale_exceptions/settings/sale.exception.csv'
--- sale_exceptions/settings/sale.exception.csv	1970-01-01 00:00:00 +0000
+++ sale_exceptions/settings/sale.exception.csv	2013-11-15 12:55:43 +0000
@@ -0,0 +1,5 @@
+"id","name","description","sequence","model","code","active"
+"excep_no_zip","No ZIP code on destination",,50,"sale.order","if not order.partner_shipping_id.zip:
+    failed=True",False
+"excep_no_stock","Not Enough Virtual Stock",,50,"sale.order.line","if line.product_id and line.product_id.type == 'product' and line.product_id.virtual_available < line.product_uom_qty:
+    failed=True",False
 
=== added directory 'sale_exceptions/wizard'
=== added file 'sale_exceptions/wizard/__init__.py'
--- sale_exceptions/wizard/__init__.py	1970-01-01 00:00:00 +0000
+++ sale_exceptions/wizard/__init__.py	2013-11-15 12:55:43 +0000
@@ -0,0 +1,24 @@
+# -*- coding: utf-8 -*-
+##############################################################################
+#
+#    OpenERP, Open Source Management Solution
+#    Copyright (C) 2011 Akretion LTDA.
+#    authors: Raphaël Valyi, Renato Lima
+#    Copyright (C) 2010-2012 Akretion Sébastien BEAU <[e-mail]>
+#    Copyright (C) 2012 Camptocamp SA (Guewen Baconnier)
+#
+#    This program is free software: you can redistribute it and/or modify
+#    it under the terms of the GNU Affero General Public License as
+#    published by the Free Software Foundation, either version 3 of the
+#    License, or (at your option) any later version.
+#
+#    This program is distributed in the hope that it will be useful,
+#    but WITHOUT ANY WARRANTY; without even the implied warranty of
+#    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+#    GNU Affero General Public License for more details.
+#
+#    You should have received a copy of the GNU Affero General Public License
+#    along with this program.  If not, see <http://www.gnu.org/licenses/>.
+#
+##############################################################################
+from . import sale_exception_confirm
 
=== added file 'sale_exceptions/wizard/sale_exception_confirm.py'
--- sale_exceptions/wizard/sale_exception_confirm.py	1970-01-01 00:00:00 +0000
+++ sale_exceptions/wizard/sale_exception_confirm.py	2013-11-15 12:55:43 +0000
@@ -0,0 +1,62 @@
+# -*- coding: utf-8 -*-
+##############################################################################
+#
+#    Copyright Camptocamp SA
+#    @author: Guewen Baconnier
+#
+#    This program is free software: you can redistribute it and/or modify
+#    it under the terms of the GNU General Public License as published by
+#    the Free Software Foundation, either version 3 of the License, or
+#    (at your option) any later version.
+#
+#    This program is distributed in the hope that it will be useful,
+#    but WITHOUT ANY WARRANTY; without even the implied warranty of
+#    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+#    GNU General Public License for more details.
+#
+#    You should have received a copy of the GNU General Public License
+#    along with this program.  If not, see <http://www.gnu.org/licenses/>.
+#
+##############################################################################
+from openerp.osv import orm, fields
+
+
+class SaleExceptionConfirm(orm.TransientModel):
+
+    _name = 'sale.exception.confirm'
+
+    _columns = {
+        'sale_id': fields.many2one('sale.order', 'Sale'),
+        'exception_ids': fields.many2many('sale.exception',
+                                          string='Exceptions to resolve',
+                                          readonly=True),
+        'ignore': fields.boolean('Ignore Exceptions'),
+    }
+
+    def default_get(self, cr, uid, fields, context=None):
+        if context is None:
+            context = {}
+        res = super(SaleExceptionConfirm, self).default_get(
+            cr, uid, fields, context=context)
+        order_obj = self.pool.get('sale.order')
+        sale_id = context.get('active_ids')
+        assert len(sale_id) == 1, "Only 1 ID accepted, got %r" % sale_id
+        sale_id = sale_id[0]
+        sale = order_obj.browse(cr, uid, sale_id, context=context)
+        exception_ids = [e.id for e in sale.exceptions_ids]
+        res.update({'exception_ids': [(6, 0, exception_ids)]})
+        res.update({'sale_id': sale_id})
+        return res
+
+    def action_confirm(self, cr, uid, ids, context=None):
+        if hasattr(ids, '__iter__'):
+            assert len(ids) == 1, "Only 1 ID accepted, got %r" % ids
+            ids = ids[0]
+        form = self.browse(cr, uid, ids, context=context)
+        if form.ignore:
+            self.pool.get('sale.order').write(
+                cr, uid,
+                form.sale_id.id,
+                {'ignore_exceptions': True},
+                context=context)
+        return {'type': 'ir.actions.act_window_close'}
 
=== added file 'sale_exceptions/wizard/sale_exception_confirm_view.xml'
--- sale_exceptions/wizard/sale_exception_confirm_view.xml	1970-01-01 00:00:00 +0000
+++ sale_exceptions/wizard/sale_exception_confirm_view.xml	2013-11-15 12:55:43 +0000
@@ -0,0 +1,39 @@
+<?xml version="1.0" encoding="utf-8"?>
+<openerp>
+    <data>
+
+        <record id="view_sale_exception_confirm" model="ir.ui.view">
+            <field name="name">Sale Exceptions</field>
+            <field name="model">sale.exception.confirm</field>
+            <field name="arch" type="xml">
+                <form string="Blocked in draft due to exceptions" version="7.0">
+                    <group>
+                        <field name="exception_ids" nolabel="1" colspan="4">
+                            <tree string="Sale Exceptions">
+                                <field name="name"/>
+                                <field name="description"/>
+                            </tree>
+                        </field>
+                        <newline/>
+                        <field name="ignore" groups='base.group_sale_manager'/>
+                    </group>
+                    <footer>
+                        <button name="action_confirm" string="_Close"
+                            colspan="1" type="object" icon="gtk-ok" />
+                    </footer>
+                </form>
+            </field>
+        </record>
+
+        <record id="action_sale_exception_confirm" model="ir.actions.act_window">
+            <field name="name">Blocked in draft due to exceptions</field>
+            <field name="type">ir.actions.act_window</field>
+            <field name="res_model">sale.exception.confirm</field>
+            <field name="view_type">form</field>
+            <field name="view_mode">form</field>
+            <field name="view_id" ref="view_sale_exception_confirm"/>
+            <field name="target">new</field>
+        </record>
+
+    </data>
+</openerp>