Merge lp:~openerp-commiter/openobject-client/many2many_dbl_click_open_new_tab-trunk into lp:openobject-client

Proposed by Nicolas DS
Status: Merged
Merge reported by: Naresh(OpenERP)
Merged at revision: not available
Proposed branch: lp:~openerp-commiter/openobject-client/many2many_dbl_click_open_new_tab-trunk
Merge into: lp:openobject-client
Diff against target: 33 lines (+10/-1)
1 file modified
bin/widget/view/form_gtk/many2many.py (+10/-1)
To merge this branch: bzr merge lp:~openerp-commiter/openobject-client/many2many_dbl_click_open_new_tab-trunk
Reviewer Review Type Date Requested Status
Naresh(OpenERP) Approve
Review via email: mp+19971@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Nicolas DS (zyphos) wrote :

Double click on a many2many widget open a new tab with the clicked resource in a form. Like Web client does.

Revision history for this message
Naresh(OpenERP) (nch-openerp) wrote :

Hello Nicolas DS,

Thank you for your Input.

I had reviewed and made a bit modification like instead of opening in a new tab allow the user to open a specific record (with a dialog as like as the one2many field) for modification.

and has been merge in trunk client with revision info as 1172 <email address hidden>

Thanks

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'bin/widget/view/form_gtk/many2many.py'
--- bin/widget/view/form_gtk/many2many.py 2010-02-11 13:19:57 +0000
+++ bin/widget/view/form_gtk/many2many.py 2010-02-23 14:09:20 +0000
@@ -33,6 +33,7 @@
33import interface33import interface
3434
35import rpc35import rpc
36import service
3637
37from modules.gui.window.win_search import win_search38from modules.gui.window.win_search import win_search
3839
@@ -72,7 +73,8 @@
72 scroll.set_shadow_type(gtk.SHADOW_NONE)73 scroll.set_shadow_type(gtk.SHADOW_NONE)
7374
74 self.screen = Screen(attrs['relation'], view_type=['tree'],75 self.screen = Screen(attrs['relation'], view_type=['tree'],
75 views_preload=attrs.get('views', {}))76 views_preload=attrs.get('views', {}),
77 row_activate=self.row_activate)
76 self.screen.type = 'many2many'78 self.screen.type = 'many2many'
77 scroll.add_with_viewport(self.screen.widget)79 scroll.add_with_viewport(self.screen.widget)
78 self.widget.pack_start(scroll, expand=True, fill=True)80 self.widget.pack_start(scroll, expand=True, fill=True)
@@ -165,5 +167,12 @@
165 def grab_focus(self):167 def grab_focus(self):
166 return self.wid_text.grab_focus()168 return self.wid_text.grab_focus()
167169
170 def row_activate(self, screen):
171 """ Open new tab with the resource in it """
172 gui_window = service.LocalService('gui.window')
173 domain = [('id','in', screen.ids_get())]
174 gui_window.create(None, screen.name, screen.id_get(), domain, u'form',
175 screen.window, screen.context, u'form,tree')
176
168# vim:expandtab:smartindent:tabstop=4:softtabstop=4:shiftwidth=4:177# vim:expandtab:smartindent:tabstop=4:softtabstop=4:shiftwidth=4:
169178