Code review comment for lp:~openerp-canada/openobject-addons/l10n_ca_chart_of_taxes_decimal_precision

Merci

On Fri, Dec 31, 2010 at 3:04 AM, Fabien (Open ERP) <email address hidden> wrote:

> Hello,
>
> Yes, I configured l10n_ca so that is supports this for the Quebec. It's
> a tax having two children. Commited in trunk.
>
> fblauer wrote:
> > Just wanted to mention that in Quebec the 8.5 % QST is on top of the
> federal
> > tax (GST). Is the system able to handle tax on tax? If not, more than 2
> > decimals is required to adjust the rate to compensate.
> >
> > On Wed, Dec 29, 2010 at 2:39 PM, Fabien (Open ERP) <email address hidden>
> wrote:
> >
> >> Hello,
> >>
> >> Thank you for your contribution. I merged the branch with the following
> >> changes:
> >> - I fixed the TPS+TVQ tax which is correct now.
> >> - I put the TVQ to 8.5
> >> - I removed decimal to 3 digits, because you don't need to do that to
> >> support taxes of 8.5% (and it
> >> may generate impacts on others modules)
> >> --
> >>
> >>
> https://code.launchpad.net/~openerp-canada/openobject-addons/l10n_ca_chart_of_taxes_decimal_precision/+merge/40590<https://code.launchpad.net/%7Eopenerp-canada/openobject-addons/l10n_ca_chart_of_taxes_decimal_precision/+merge/40590>
> <
> https://code.launchpad.net/%7Eopenerp-canada/openobject-addons/l10n_ca_chart_of_taxes_decimal_precision/+merge/40590
> >
> >> Your team OpenERP Canada Team is subscribed to branch
> >>
> lp:~openerp-canada/openobject-addons/l10n_ca_chart_of_taxes_decimal_precision.
> >>
> >> _______________________________________________
> >> Mailing list: https://launchpad.net/~openerp-canada<https://launchpad.net/%7Eopenerp-canada>
> <https://launchpad.net/%7Eopenerp-canada>
> >> Post to : <email address hidden>
> >> Unsubscribe : https://launchpad.net/~openerp-canada<https://launchpad.net/%7Eopenerp-canada>
> <https://launchpad.net/%7Eopenerp-canada>
> >> More help : https://help.launchpad.net/ListHelp
> >>
> >
> >
> >
>
>
> --
> Fabien Pinckaers
> CEO OpenERP
> Chaussée de Namur 40
> B-1367 Grand-Rosière
> Belgium
> Phone: +32.81.81.37.00
> Fax: +32.81.73.35.01
> Web: http://openerp.com
>
> https://code.launchpad.net/~openerp-canada/openobject-addons/l10n_ca_chart_of_taxes_decimal_precision/+merge/40590<https://code.launchpad.net/%7Eopenerp-canada/openobject-addons/l10n_ca_chart_of_taxes_decimal_precision/+merge/40590>
> Your team OpenERP Canada Team is subscribed to branch
> lp:~openerp-canada/openobject-addons/l10n_ca_chart_of_taxes_decimal_precision.
>
> _______________________________________________
> Mailing list: https://launchpad.net/~openerp-canada<https://launchpad.net/%7Eopenerp-canada>
> Post to : <email address hidden>
> Unsubscribe : https://launchpad.net/~openerp-canada<https://launchpad.net/%7Eopenerp-canada>
> More help : https://help.launchpad.net/ListHelp
>

--
Fred Blauer CA, CA.IT, CISA
http://openacct.ca
<email address hidden>
514-667-1555