Code review comment for lp:~openbmsjsc/openobject-addons/addons-extra-trunk-l10n_vn

Hi Olivier,

Thank you very much for your detailed comments on improvements/clean-up that I'll need to perform. I'll make those changes ASAP, for proposal to be included in the next release of OpenERP.

I have several questions regarding this clean-up.

1. The Chart of Accounts defines skeletons of accounts, and companies can further refine/define sub-accounts for its purposes (e.g. separate different taxes schedules/rates into different sub-accounts under the same top-level accounts. Some companies just put all taxes into 1 accounts. In this case, as a template, what type these accounts (that can be optionally sub-defined) should have: the view or something else? If I use the "view" type, then in local module, where I extend/create sub-accounts, even I re-define the type of the parent account to "view", OpenERP still complains and doesn't allow me to change and create sub-accounts. Other the other hand, if I use any type other than "view", OpenERP certainly will not allow me to create sub-accounts.

2. For language localization, what should be the best practice: keep all the native language as the primary (i.e. exported in .pot file) and provide English (and any other translations) as .po files, or I should use English as the main language and have Vietnamese as a translation? The 2nd seems to be the standard approach, but as you said that the account types will not be translated ==> this doesn't work.

I'm looking forward to hearing from your feedback soon to making good progress with this module.

Thanks and best regards,

Phong.