Merge lp:~openbig/bigconsulting/new_changes_in_account_invoice_cash_discount into lp:bigconsulting

Proposed by gpa(OpenERP)
Status: Merged
Merged at revision: 24
Proposed branch: lp:~openbig/bigconsulting/new_changes_in_account_invoice_cash_discount
Merge into: lp:bigconsulting
Diff against target: 77 lines (+17/-25)
1 file modified
account_invoice_cash_discount/account_invoice_cash_discount.py (+17/-25)
To merge this branch: bzr merge lp:~openbig/bigconsulting/new_changes_in_account_invoice_cash_discount
Reviewer Review Type Date Requested Status
openbig Pending
Review via email: mp+27912@code.launchpad.net

Description of the change

changes in the calculation of discount and changes name of the variables

To post a comment you must log in.
25. By gpa(OpenERP)

remove extra lines

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'account_invoice_cash_discount/account_invoice_cash_discount.py'
--- account_invoice_cash_discount/account_invoice_cash_discount.py 2010-08-05 13:41:54 +0000
+++ account_invoice_cash_discount/account_invoice_cash_discount.py 2010-06-18 10:00:47 +0000
@@ -61,8 +61,8 @@
61 tax_obj = self.pool.get('account.tax')61 tax_obj = self.pool.get('account.tax')
62 invoice = self.browse(cr, uid, ids[0], context=context)62 invoice = self.browse(cr, uid, ids[0], context=context)
63 63
64 if invoice.date_due:64 if invoice.date_invoice:
65 date1 = invoice.date_due65 date1 = invoice.date_invoice
66 else:66 else:
67 date1 = time.strftime('%Y-%m-%d')67 date1 = time.strftime('%Y-%m-%d')
68 68
@@ -81,24 +81,16 @@
81 diff_day = (from_dt-to_dt)/(3600*24)81 diff_day = (from_dt-to_dt)/(3600*24)
82 discount = 0.082 discount = 0.0
83 if payment_term:83 if payment_term:
84 pt = self.pool.get('account.payment.term').browse(cr, uid, payment_term, context=context)84 payment_term_lines = self.pool.get('account.payment.term').browse(cr, uid, payment_term, context=context)
85 if pt.cash_discount_ids:85 if payment_term_lines.cash_discount_ids:
86 res = 0.086 res = 0.0
87 dis = 087 dis = 0
88 for d in pt.cash_discount_ids:88 for discount_line in payment_term_lines.cash_discount_ids:
89 if diff_day > dis and diff_day <= d.delay:89 if diff_day > dis and diff_day <= discount_line.delay:
90 if resudial_amonut:90 if resudial_amonut:
91 res = resudial_amonut * d.discount91 res = resudial_amonut * discount_line.discount
92 ted = 0.092 discount = res
93 for line in invoice.invoice_line:93 dis = discount_line.delay
94 if line.invoice_line_tax_id:
95 tt = tax_obj.compute_inv(cr, uid, line.invoice_line_tax_id, res, line.quantity)
96 for tex in tt:
97 rr = 0.0
98 rr += tex['amount']
99 ted +=rr
100 discount = res + ted
101 dis = d.delay
102 return discount94 return discount
103 95
104 def _get_account(self, cr, uid, ids, resudial_amonut, payment_term, context=None):96 def _get_account(self, cr, uid, ids, resudial_amonut, payment_term, context=None):
@@ -113,9 +105,9 @@
113 tax_obj = self.pool.get('account.tax')105 tax_obj = self.pool.get('account.tax')
114 invoice = self.browse(cr, uid, ids[0], context=context)106 invoice = self.browse(cr, uid, ids[0], context=context)
115 107
116 if invoice.date_due:108 if invoice.date_invoice:
117 date1 = invoice.date_due109 date1 = invoice.date_invoice
118 else:110 else:
119 date1 = time.strftime('%Y-%m-%d')111 date1 = time.strftime('%Y-%m-%d')
120 112
121 if 'date_p' in context and context['date_p']: 113 if 'date_p' in context and context['date_p']:
@@ -133,12 +125,12 @@
133 diff_day = (from_dt-to_dt)/(3600*24) 125 diff_day = (from_dt-to_dt)/(3600*24)
134126
135 if payment_term:127 if payment_term:
136 pt = self.pool.get('account.payment.term').browse(cr, uid, payment_term, context=context)128 payment_term_lines = self.pool.get('account.payment.term').browse(cr, uid, payment_term, context=context)
137 if pt.cash_discount_ids:129 if payment_term_lines.cash_discount_ids:
138 res = 0.0130 res = 0.0
139 for d in pt.cash_discount_ids:131 for discount_line in payment_term_lines.cash_discount_ids:
140 if diff_day == d.delay or diff_day < d.delay:132 if diff_day == discount_line.delay or diff_day < discount_line.delay:
141 account_id = d.discount_account_id.id133 account_id = discount_line.discount_account_id.id
142 return account_id 134 return account_id
143 135
144 def pay_and_reconcile(self, cr, uid, ids, pay_amount, pay_account_id, period_id, pay_journal_id, writeoff_acc_id, writeoff_period_id, writeoff_journal_id, context=None, name=''):136 def pay_and_reconcile(self, cr, uid, ids, pay_amount, pay_account_id, period_id, pay_journal_id, writeoff_acc_id, writeoff_period_id, writeoff_journal_id, context=None, name=''):

Subscribers

People subscribed via source and target branches