Code review comment for lp:~openbig/bigconsulting/Wizard_minimum_stock_rules

Revision history for this message
Husen Daudi (husendaudi) wrote :

I reviewed your code and need some improvement in code.
Please follow this point in future development.

In __terp__.py file
"author": "Big Consulting",
"website" : "",
"category": "",
"description": """
""",

website should be there for big consulting, proper module category should be there,
 There must be detailed description required for each module.

In python file

from osv import fields, osv
from osv import fields, osv
from tools.translate import _
import netsvc
import pooler
import time
import tools
import wizard

duplication of import statement
from osv import fields, osv

remove useless imports
mport netsvc
import pooler
import time
import tools
import wizard

In each python file we must have
first line:
# -*- encoding: utf-8 -*-

in bottom last line:
# vim:expandtab:smartindent:tabstop=4:softtabstop=4:shiftwidth=4:

« Back to merge proposal