Code review comment for lp:~oontvoo/akiban-server/bug_drop_fulltext_index

Revision history for this message
Nathan Williams (nwilliams) wrote :

akserver.text.indexpath is already in both configuration-defaults and TestConfigService, so it shouldn't be needed in PSMYIT. Moving the interval setting into TestConfigService might be good, as it is now in 3 places.

The new getIndexToDrop() helper is misleading. It will throw NoSuchIndex if the cache hasn't been created (e.g. create a FT and then immediately drop). Using the existing method is fine. Attempting to optimize away the Info creation is just noise.

Otherwise looks good.

review: Needs Fixing

« Back to merge proposal