Code review comment for lp:~onox/awn-extras/common-folder-applet

Revision history for this message
Michal Hruby (mhr3) wrote :

As always with applets that duplicate functionality of other applets I don't like it. As you alone said, currently the applet doesn't really provide any benefits to f-b-l, besides that it doesn't do configuration (which is a questionable "benefit"). IMO it'd be much better to fix fbl issues, than to write completely new applet, and when you do write completely new applet, it should try to replace said applet, ie. provide feature-parity or at least other significant benefits (like being faster/more mem efficient etc)...

But ultimately this has been practised for quite some time in extras, so I'll leave the merging up to you...

review: Abstain

« Back to merge proposal