Merge lp:~online-accounts/signon/packaging into lp:signon

Proposed by Alberto Mardegan
Status: Merged
Approved by: David Barth
Approved revision: no longer in the source branch.
Merged at revision: 626
Proposed branch: lp:~online-accounts/signon/packaging
Merge into: lp:signon
Diff against target: 86 lines (+15/-6)
5 files modified
debian/changelog (+9/-0)
lib/SignOn/authsession.h (+2/-1)
lib/SignOn/authsessionimpl.cpp (+2/-0)
lib/plugins/signon-plugins-common/SignOn/blobiohandler.cpp (+1/-0)
src/signond/signondaemon.cpp (+1/-5)
To merge this branch: bzr merge lp:~online-accounts/signon/packaging
Reviewer Review Type Date Requested Status
PS Jenkins bot (community) continuous-integration Approve
Online Accounts Pending
Review via email: mp+257252@code.launchpad.net

Commit message

* Merge from upstream

- lib: reset the DBus proxy when registration failed
- Fix build with Qt 5.5 (LP: #1447175)

Description of the change

* Merge from upstream

- lib: reset the DBus proxy when registration failed
- Fix build with Qt 5.5 (LP: #1447175)

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
lp:~online-accounts/signon/packaging updated
626. By Alberto Mardegan

* Merge from upstream

- lib: reset the DBus proxy when registration failed
- Fix build with Qt 5.5 (LP: #1447175)
 Fixes: #1415492
Approved by: PS Jenkins bot

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'debian/changelog'
--- debian/changelog 2015-02-04 10:39:42 +0000
+++ debian/changelog 2015-06-12 11:22:36 +0000
@@ -1,3 +1,12 @@
1signon (8.57+15.04.20150204.1-0ubuntu3) UNRELEASED; urgency=medium
2
3 * Merge from upstream
4 - lib: reset the DBus proxy when registration failed
5 - Fix build with Qt 5.5 (LP: #1447175)
6 - Remove obsolete warning about not running as root
7
8 -- Alberto Mardegan <alberto.mardegan@canonical.com> Fri, 12 Jun 2015 14:17:06 +0300
9
1signon (8.57+15.04.20150204.1-0ubuntu1) vivid; urgency=medium10signon (8.57+15.04.20150204.1-0ubuntu1) vivid; urgency=medium
211
3 [ Alberto Mardegan ]12 [ Alberto Mardegan ]
413
=== modified file 'lib/SignOn/authsession.h'
--- lib/SignOn/authsession.h 2013-08-20 08:01:44 +0000
+++ lib/SignOn/authsession.h 2015-06-12 11:22:36 +0000
@@ -2,6 +2,7 @@
2 * This file is part of signon2 * This file is part of signon
3 *3 *
4 * Copyright (C) 2009-2010 Nokia Corporation.4 * Copyright (C) 2009-2010 Nokia Corporation.
5 * Copyright (C) 2011-2015 Canonical Ltd.
5 *6 *
6 * Contact: Aurel Popirtac <ext-aurel.popirtac@nokia.com>7 * Contact: Aurel Popirtac <ext-aurel.popirtac@nokia.com>
7 * Contact: Alberto Mardegan <alberto.mardegan@canonical.com>8 * Contact: Alberto Mardegan <alberto.mardegan@canonical.com>
@@ -40,7 +41,7 @@
4041
41namespace SignOnTests {42namespace SignOnTests {
42 class AccessControlTest;43 class AccessControlTest;
43};44}
4445
45namespace SignOn {46namespace SignOn {
4647
4748
=== modified file 'lib/SignOn/authsessionimpl.cpp'
--- lib/SignOn/authsessionimpl.cpp 2013-07-29 11:42:18 +0000
+++ lib/SignOn/authsessionimpl.cpp 2015-06-12 11:22:36 +0000
@@ -247,6 +247,8 @@
247 m_isAuthInProcessing = false;247 m_isAuthInProcessing = false;
248248
249 m_dbusProxy.setError(err);249 m_dbusProxy.setError(err);
250 // Forces a reinitialization of the proxy
251 m_dbusProxy.setObjectPath(QDBusObjectPath());
250 return;252 return;
251 }253 }
252254
253255
=== modified file 'lib/plugins/signon-plugins-common/SignOn/blobiohandler.cpp'
--- lib/plugins/signon-plugins-common/SignOn/blobiohandler.cpp 2014-04-10 10:31:10 +0000
+++ lib/plugins/signon-plugins-common/SignOn/blobiohandler.cpp 2015-06-12 11:22:36 +0000
@@ -25,6 +25,7 @@
2525
26#include <QDBusArgument>26#include <QDBusArgument>
27#include <QBuffer>27#include <QBuffer>
28#include <QDataStream>
28#include <QDebug>29#include <QDebug>
2930
30#include "SignOn/signonplugincommon.h"31#include "SignOn/signonplugincommon.h"
3132
=== modified file 'src/signond/signondaemon.cpp'
--- src/signond/signondaemon.cpp 2015-02-04 09:37:26 +0000
+++ src/signond/signondaemon.cpp 2015-06-12 11:22:36 +0000
@@ -2,7 +2,7 @@
2 * This file is part of signon2 * This file is part of signon
3 *3 *
4 * Copyright (C) 2009-2010 Nokia Corporation.4 * Copyright (C) 2009-2010 Nokia Corporation.
5 * Copyright (C) 2013 Canonical Ltd.5 * Copyright (C) 2013-2015 Canonical Ltd.
6 *6 *
7 * Contact: Aurel Popirtac <ext-aurel.popirtac@nokia.com>7 * Contact: Aurel Popirtac <ext-aurel.popirtac@nokia.com>
8 * Contact: Alberto Mardegan <alberto.mardegan@canonical.com>8 * Contact: Alberto Mardegan <alberto.mardegan@canonical.com>
@@ -386,10 +386,6 @@
386386
387 m_configuration->load();387 m_configuration->load();
388388
389 if (getuid() != 0) {
390 BLAME() << "Failed to SUID root. Secure storage will not be available.";
391 }
392
393 QCoreApplication *app = QCoreApplication::instance();389 QCoreApplication *app = QCoreApplication::instance();
394 if (!app)390 if (!app)
395 qFatal("SignonDaemon requires a QCoreApplication instance to be "391 qFatal("SignonDaemon requires a QCoreApplication instance to be "

Subscribers

No one subscribed via source and target branches