Code review comment for lp:~om26er/unity8/unlocker_fix_non_working_code

> Hi Omer,
>
> Good catch with greeter not being None.
>
> WRT raising an exception or logging; My thought process was that someone might
> want the greeter to be locked and thus would like to be alerted of that.

right, that might be really rare case but in the current form we have multiple problems i.e. only the first test passing and every other after that failing due to screen being unlocked.

>
> As it currently stands callers of unlock_unity() can wrap the call in a
> try..except.

This will result in each app doing exactly the same thing in its code, why not provide a reusable ensure_screen_unlock() ?

> I'm not married to this though and perhaps there is an argument that I'm
> trying to solve a problem that doesn't exist and that just logging makes the
> code cleaner and easier then we should change it to just log instead.

Lets move the conversation over to bug 1250458