Code review comment for lp:~om26er/unity8/unlocker_fix_non_working_code

Revision history for this message
Christopher Lee (veebers) wrote :

Hi Omer,

Good catch with greeter not being None.

WRT raising an exception or logging; My thought process was that someone might want the greeter to be locked and thus would like to be alerted of that.

As it currently stands callers of unlock_unity() can wrap the call in a try..except.
I'm not married to this though and perhaps there is an argument that I'm trying to solve a problem that doesn't exist and that just logging makes the code cleaner and easier then we should change it to just log instead.

review: Approve

« Back to merge proposal