Code review comment for lp:~om26er/unity8/unlocker_fix_non_working_code

Revision history for this message
Omer Akram (om26er) wrote :

I trying to get this change merged for the code to atleast work but I think this part of the code does not make sense.

If the unlocker is to be consumed by our apps their tests will fail because whenever we run a test suite of an app while the screen is unlocked the tests would fail or even if the tests are run with the screen locked after the first test runs every next test will fail since the screen will be unlocked. Instead of raising a warning I think it would make more sense to just use the python logger to log that the screen is already unlocked.

« Back to merge proposal