Merge lp:~om26er/ubuntu/natty/totem/totem-fix-696171-3 into lp:~ubuntu-desktop/totem/ubuntu

Proposed by Omer Akram
Status: Merged
Merged at revision: 92
Proposed branch: lp:~om26er/ubuntu/natty/totem/totem-fix-696171-3
Merge into: lp:~ubuntu-desktop/totem/ubuntu
Diff against target: 111 lines (+91/-0)
3 files modified
debian/changelog (+7/-0)
debian/patches/add_show_tooltip_uri_property.patch (+83/-0)
debian/patches/series (+1/-0)
To merge this branch: bzr merge lp:~om26er/ubuntu/natty/totem/totem-fix-696171-3
Reviewer Review Type Date Requested Status
Ubuntu Desktop Pending
Review via email: mp+45140@code.launchpad.net

Description of the change

it turns out there were two commits needed to fix bug 696171 so now backported the second commit too.

To post a comment you must log in.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/changelog'
2--- debian/changelog 2011-01-04 05:58:45 +0000
3+++ debian/changelog 2011-01-04 16:41:24 +0000
4@@ -1,3 +1,10 @@
5+totem (2.32.0-0ubuntu5) natty; urgency=low
6+
7+ * debian/patches/add_show_tooltip_uri_property.patch:
8+ - Really don't show youtube URLs in tooltips. (LP: #696171)
9+
10+ -- Omer Akram <om26er@ubuntu.com> Tue, 04 Jan 2011 21:32:04 +0500
11+
12 totem (2.32.0-0ubuntu4) natty; urgency=low
13
14 * debian/patches/dont_display_URIs_in_youtube_tooltips.patch:
15
16=== added file 'debian/patches/add_show_tooltip_uri_property.patch'
17--- debian/patches/add_show_tooltip_uri_property.patch 1970-01-01 00:00:00 +0000
18+++ debian/patches/add_show_tooltip_uri_property.patch 2011-01-04 16:41:24 +0000
19@@ -0,0 +1,83 @@
20+From: Philip Withnall <philip@tecnocode.co.uk>
21+Subject: Add a TotemVideoList::show-tooltip-uri property.
22+Origin: http://git.gnome.org/browse/totem/commit/?id=19857f506a3ff83b14ce461072ce4edadd612557
23+Bug: https://bugs.gnome.org/629548
24+Bug-Ubuntu: https://launchpad.net/bugs/696171
25+
26+--- a/src/totem-video-list.c
27++++ b/src/totem-video-list.c
28+@@ -58,6 +58,7 @@ struct _TotemVideoListPrivate {
29+ GtkBuilder *xml;
30+ GtkActionGroup *action_group;
31+ GtkUIManager *ui_manager;
32++ gboolean show_tooltip_uri;
33+ };
34+
35+ #define TOTEM_VIDEO_LIST_GET_PRIVATE(obj) (G_TYPE_INSTANCE_GET_PRIVATE ((obj), TOTEM_TYPE_VIDEO_LIST, TotemVideoListPrivate))
36+@@ -65,7 +66,8 @@ struct _TotemVideoListPrivate {
37+ enum {
38+ PROP_TOOLTIP_COLUMN = 1,
39+ PROP_MRL_COLUMN,
40+- PROP_TOTEM
41++ PROP_TOTEM,
42++ PROP_SHOW_TOOLTIP_URI
43+ };
44+
45+ enum {
46+@@ -156,6 +158,18 @@ totem_video_list_class_init (TotemVideoListClass *klass)
47+ TOTEM_TYPE_OBJECT, G_PARAM_READWRITE));
48+
49+ /**
50++ * TotemVideoList:show-tooltip-uri:
51++ *
52++ * If this is %TRUE, the URI of each video will be displayed in the tooltip for that video (or a message saying "No video URI" will be
53++ * displayed if the URI is unset); otherwise, the tooltip will only display the video name.
54++ *
55++ * Since: 2.90.6
56++ **/
57++ g_object_class_install_property (object_class, PROP_SHOW_TOOLTIP_URI,
58++ g_param_spec_boolean ("show-tooltip-uri", NULL, NULL,
59++ TRUE, G_PARAM_READWRITE));
60++
61++ /**
62+ * TotemVideoList::starting-video:
63+ * @video_list: the #TotemVideoList which received the signal
64+ * @tree_path: the #GtkTreePath of the video row about to be played
65+@@ -184,6 +198,7 @@ totem_video_list_init (TotemVideoList *self)
66+ self->priv->totem = NULL;
67+ self->priv->tooltip_column = -1;
68+ self->priv->mrl_column = -1;
69++ self->priv->show_tooltip_uri = TRUE;
70+
71+ /* Get the interface */
72+ self->priv->xml = totem_interface_load ("video-list.ui", TRUE, NULL, self);
73+@@ -246,6 +261,10 @@ totem_video_list_set_property (GObject *object, guint property_id, const GValue
74+ priv->totem = (Totem*) g_value_dup_object (value);
75+ g_object_notify (object, "totem");
76+ break;
77++ case PROP_SHOW_TOOLTIP_URI:
78++ priv->show_tooltip_uri = g_value_get_boolean (value);
79++ g_object_notify (object, "show-tooltip-uri");
80++ break;
81+ default:
82+ G_OBJECT_WARN_INVALID_PROPERTY_ID (object, property_id, pspec);
83+ }
84+@@ -267,6 +286,9 @@ totem_video_list_get_property (GObject *object, guint property_id, GValue *value
85+ case PROP_TOTEM:
86+ g_value_set_object (value, G_OBJECT (priv->totem));
87+ break;
88++ case PROP_SHOW_TOOLTIP_URI:
89++ g_value_set_boolean (value, priv->show_tooltip_uri);
90++ break;
91+ default:
92+ G_OBJECT_WARN_INVALID_PROPERTY_ID (object, property_id, pspec);
93+ }
94+@@ -292,7 +314,7 @@ query_tooltip_cb (GtkWidget *widget, gint x, gint y, gboolean keyboard_mode, Gtk
95+ &model, &path, &iter))
96+ return FALSE;
97+
98+- if (self->priv->mrl_column == -1) {
99++ if (self->priv->mrl_column == -1 || self->priv->show_tooltip_uri == FALSE) {
100+ gtk_tree_model_get (model, &iter, self->priv->tooltip_column, &tooltip_text, -1);
101+ gtk_tooltip_set_text (tooltip, tooltip_text);
102+ g_free (tooltip_text);
103
104=== modified file 'debian/patches/series'
105--- debian/patches/series 2011-01-04 05:58:45 +0000
106+++ debian/patches/series 2011-01-04 16:41:24 +0000
107@@ -1,3 +1,4 @@
108+add_show_tooltip_uri_property.patch
109 dont_display_URIs_in_youtube_tooltips.patch
110 01_fake_keypresses.patch
111 02_lpi.patch

Subscribers

People subscribed via source and target branches

to all changes: