Code review comment for lp:~om26er/ubuntu-calendar-app/autopilot_tests_bootstrap

Revision history for this message
Olivier Tilloy (osomon) wrote :

133 + def get_toolbar_button(self, button_idx):
134 + toolbar = self.app.select_single("Toolbar")
135 + item = toolbar.get_children_by_type("QQuickItem")[0]
136 + row = item.get_children_by_type("QQuickRow")[0]
137 + button_loaders = row.get_children_by_type("QQuickLoader")
138 + button_loader = button_loaders[button_idx]
139 + return button_loader

This can be greatly simplified:

    def get_toolbar_button(self, button_idx):
        toolbar = self.app.select_single("Toolbar")
        row = toolbar.select_single("QQuickRow")
        buttons = row.select_many("Button")
        return buttons[button_idx]

review: Needs Fixing

« Back to merge proposal