Code review comment for lp:~om26er/ubuntu-calendar-app/autopilot_tests_bootstrap

Revision history for this message
Olivier Tilloy (osomon) wrote :

163 +class CalendarTestCase(CalendarTestCase):

It looks unwise to give a class the exact same name as its parent.

As a suggestion, in the webbrowser-app, the names of all the actual test cases begin with "Test", e.g.:

    class TestWindowTitle(BrowserTestCaseBase):

Feel free to choose a different naming scheme, but in any case do not use the same name as the base class.

review: Needs Fixing

« Back to merge proposal