Code review comment for lp:~om26er/kubuntu-packaging/qtmultimedia_unittests

Revision history for this message
Dmitry Shachnev (mitya57) wrote :

Thanks for working on it!

> cd tests/auto/unit/ && ( test -e Makefile || qmake unit.pro -o Makefile ) && make -f Makefile check

That looks quite complicated. Take a look at i.e. qtsvg, where a simple dh_auto_test worked (though we explicitly told qmake to enable tests).

dh_auto_test is usually better because it takes care of things like DEB_BUILD_OPTIONS=nocheck.

P.S. Special thanks for adding bug numbers (though you may also want to use the DEP-3 format).

review: Abstain

« Back to merge proposal