Code review comment for lp:~om26er/gallery-app/camera-integration-test

Revision history for this message
Olivier Tilloy (osomon) wrote :

41 + def setUp(self):
42 + super(TestCameraIntegration, self).setUp()

If all you do in call super, then this is useless, you can remove the setUp() method entirely.

44 + def tearDown(self):
45 + super(TestCameraIntegration, self).tearDown()
46 + os.system("pkill camera-app")

camera-app should be killed before calling super(…).tearDown() (specific clean-up happens before the one inherited from the parent class).

review: Needs Fixing

« Back to merge proposal