Merge lp:~om26er/camera-app/fix_autopilot_test_code into lp:camera-app

Proposed by Omer Akram
Status: Rejected
Rejected by: Florian Boucault
Proposed branch: lp:~om26er/camera-app/fix_autopilot_test_code
Merge into: lp:camera-app
Diff against target: 428 lines (+89/-65)
6 files modified
tests/autopilot/camera_app/emulators/main_window.py (+21/-8)
tests/autopilot/camera_app/tests/__init__.py (+7/-6)
tests/autopilot/camera_app/tests/test_capture.py (+21/-16)
tests/autopilot/camera_app/tests/test_flash.py (+9/-10)
tests/autopilot/camera_app/tests/test_focus.py (+24/-16)
tests/autopilot/camera_app/tests/test_zoom.py (+7/-9)
To merge this branch: bzr merge lp:~om26er/camera-app/fix_autopilot_test_code
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Needs Fixing
Ugo Riboni (community) Approve
Review via email: mp+195618@code.launchpad.net

Commit message

fixes pyflakes and pep8 complaints in the autopilot code. Also improves the readability.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Ugo Riboni (uriboni) wrote :

Looks ok and passes

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)

Unmerged revisions

232. By Omer Akram

fix conflicts, merge trunk

231. By Omer Akram

True in this case is actually a string not bool

230. By Omer Akram

bring docstring inside test cases instead of being outside

229. By Omer Akram

move the check to make sure app window have appeared on screen into a central place, instead of doing the same thing in each Class

228. By Omer Akram

fix pyflakes complaints

227. By Omer Akram

fix all pep8 complaints

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'tests/autopilot/camera_app/emulators/main_window.py'
--- tests/autopilot/camera_app/emulators/main_window.py 2013-11-18 10:15:15 +0000
+++ tests/autopilot/camera_app/emulators/main_window.py 2013-11-22 11:05:37 +0000
@@ -4,7 +4,7 @@
4# This program is free software: you can redistribute it and/or modify it4# This program is free software: you can redistribute it and/or modify it
5# under the terms of the GNU General Public License version 3, as published5# under the terms of the GNU General Public License version 3, as published
6# by the Free Software Foundation.6# by the Free Software Foundation.
7import math7
88
9class MainWindow(object):9class MainWindow(object):
10 """An emulator class that makes it easy to interact with the camera-app."""10 """An emulator class that makes it easy to interact with the camera-app."""
@@ -19,14 +19,19 @@
19 def get_focus_ring(self):19 def get_focus_ring(self):
20 """Returns the focus ring of the camera"""20 """Returns the focus ring of the camera"""
21 return self.app.wait_select_single("FocusRing")21 return self.app.wait_select_single("FocusRing")
22 22
23 def get_exposure_button(self):23 def get_exposure_button(self):
24 """Returns the button that takes pictures"""24 """Returns the button that takes pictures"""
25 return self.app.wait_select_single("ShootButton")25 return self.app.wait_select_single("ShootButton")
2626
27 def get_record_control(self):27 def get_record_control(self):
28 """Returns the button that switches between photo and video recording"""28 """Returns the button that switches between photo and video
29 return self.app.wait_select_single("FadingButton", objectName="recordModeButton")29 recording.
30
31 """
32 return self.app.wait_select_single(
33 "FadingButton",
34 objectName="recordModeButton")
3035
31 def get_flash_button(self):36 def get_flash_button(self):
32 """Returns the flash control button of the camera"""37 """Returns the flash control button of the camera"""
@@ -46,15 +51,21 @@
4651
47 def get_zoom_slider_button(self):52 def get_zoom_slider_button(self):
48 """Returns the zoom slider button"""53 """Returns the zoom slider button"""
49 return self.app.wait_select_single("QQuickImage", objectName="sliderThumb")54 return self.app.wait_select_single(
55 "QQuickImage",
56 objectName="sliderThumb")
5057
51 def get_zoom_plus(self):58 def get_zoom_plus(self):
52 """Returns the zoom plus button"""59 """Returns the zoom plus button"""
53 return self.app.wait_select_single("AbstractButton", objectName="zoomPlus")60 return self.app.wait_select_single(
61 "AbstractButton",
62 objectName="zoomPlus")
5463
55 def get_zoom_minus(self):64 def get_zoom_minus(self):
56 """Returns the zoom minus button"""65 """Returns the zoom minus button"""
57 return self.app.wait_select_single("AbstractButton", objectName="zoomMinus")66 return self.app.wait_select_single(
67 "AbstractButton",
68 objectName="zoomMinus")
5869
59 def get_viewfinder_geometry(self):70 def get_viewfinder_geometry(self):
60 """Returns the viewfinder geometry tracker"""71 """Returns the viewfinder geometry tracker"""
@@ -62,7 +73,9 @@
6273
63 def get_swap_camera_button(self):74 def get_swap_camera_button(self):
64 """Returns the button that switches between front and back cameras"""75 """Returns the button that switches between front and back cameras"""
65 return self.app.wait_select_single("CameraToolbarButton", objectName="swapButton")76 return self.app.wait_select_single(
77 "CameraToolbarButton",
78 objectName="swapButton")
6679
67 def get_orientation(self):80 def get_orientation(self):
68 orientation = self.app.wait_select_single("DeviceOrientation")81 orientation = self.app.wait_select_single("DeviceOrientation")
6982
=== modified file 'tests/autopilot/camera_app/tests/__init__.py'
--- tests/autopilot/camera_app/tests/__init__.py 2013-09-26 20:26:08 +0000
+++ tests/autopilot/camera_app/tests/__init__.py 2013-11-22 11:05:37 +0000
@@ -7,7 +7,6 @@
77
8"""Camera-app autopilot tests."""8"""Camera-app autopilot tests."""
99
10from os import remove
11import os.path10import os.path
1211
13from autopilot.input import Mouse, Touch, Pointer12from autopilot.input import Mouse, Touch, Pointer
@@ -26,11 +25,9 @@
2625
27 """26 """
28 if model() == 'Desktop':27 if model() == 'Desktop':
29 scenarios = [28 scenarios = [('with mouse', dict(input_device_class=Mouse))]
30 ('with mouse', dict(input_device_class=Mouse))]
31 else:29 else:
32 scenarios = [30 scenarios = [('with touch', dict(input_device_class=Touch))]
33 ('with touch', dict(input_device_class=Touch))]
3431
35 local_location = "../../camera-app"32 local_location = "../../camera-app"
36 deb_location = '/usr/bin/camera-app'33 deb_location = '/usr/bin/camera-app'
@@ -45,6 +42,9 @@
45 else:42 else:
46 self.launch_click_installed()43 self.launch_click_installed()
4744
45 self.assertThat(
46 self.main_window.get_qml_view().visible, Eventually(Equals(True)))
47
48 def launch_test_local(self):48 def launch_test_local(self):
49 self.app = self.launch_test_application(49 self.app = self.launch_test_application(
50 self.local_location)50 self.local_location)
@@ -57,7 +57,8 @@
57 self.app = self.launch_test_application(57 self.app = self.launch_test_application(
58 "camera-app",58 "camera-app",
59 "--fullscreen",59 "--fullscreen",
60 "--desktop_file_hint=/usr/share/applications/camera-app.desktop",60 "--desktop_file_hint=/usr/share/applications/"
61 "camera-app.desktop",
61 app_type='qt')62 app_type='qt')
6263
63 def launch_click_installed(self):64 def launch_click_installed(self):
6465
=== modified file 'tests/autopilot/camera_app/tests/test_capture.py'
--- tests/autopilot/camera_app/tests/test_capture.py 2013-11-18 13:34:43 +0000
+++ tests/autopilot/camera_app/tests/test_capture.py 2013-11-22 11:05:37 +0000
@@ -9,7 +9,7 @@
99
10from autopilot.matchers import Eventually10from autopilot.matchers import Eventually
11from autopilot.platform import model11from autopilot.platform import model
12from testtools.matchers import Equals, NotEquals, GreaterThan12from testtools.matchers import Equals, NotEquals
1313
14from camera_app.tests import CameraAppTestCase14from camera_app.tests import CameraAppTestCase
1515
@@ -22,25 +22,25 @@
22class TestCapture(CameraAppTestCase):22class TestCapture(CameraAppTestCase):
23 """Tests the main camera features"""23 """Tests the main camera features"""
2424
25 """ This is needed to wait for the application to start.
26 In the testfarm, the application may take some time to show up."""
27 def setUp(self):25 def setUp(self):
28 super(TestCapture, self).setUp()26 super(TestCapture, self).setUp()
29 self.assertThat(
30 self.main_window.get_qml_view().visible, Eventually(Equals(True)))
3127
32 def tearDown(self):28 def tearDown(self):
33 super(TestCapture, self).tearDown()29 super(TestCapture, self).tearDown()
3430
35 """Test taking a picture"""31 @unittest.skipIf(
36 @unittest.skipIf(model() == 'Galaxy Nexus', 'Unusable with Mir enabled on maguro')32 model() == 'Galaxy Nexus',
33 'Unusable with Mir enabled on maguro')
37 def test_take_picture(self):34 def test_take_picture(self):
38 toolbar = self.main_window.get_toolbar()35 """Test taking a picture."""
39 exposure_button = self.main_window.get_exposure_button()36 exposure_button = self.main_window.get_exposure_button()
40 pictures_dir = path.expanduser("~/Pictures")37 pictures_dir = path.expanduser("~/Pictures")
4138
42 # Remove all pictures from ~/Pictures that match our pattern39 # Remove all pictures from ~/Pictures that match our pattern
43 files = [f for f in os.listdir(pictures_dir) if f[0:5] == "image" and path.isfile(path.join(pictures_dir, f))]40 files = [
41 f for f in os.listdir(pictures_dir) if f[0:5] == "image"
42 and path.isfile(path.join(pictures_dir, f))
43 ]
44 for f in files:44 for f in files:
45 os.remove(path.join(pictures_dir, f))45 os.remove(path.join(pictures_dir, f))
4646
@@ -56,7 +56,10 @@
56 # is actually there56 # is actually there
57 one_picture_on_disk = False57 one_picture_on_disk = False
58 for i in range(0, 10):58 for i in range(0, 10):
59 files = [f for f in os.listdir(pictures_dir) if f[0:5] == "image" and path.isfile(path.join(pictures_dir, f))]59 files = [
60 f for f in os.listdir(pictures_dir) if f[0:5] == "image"
61 and path.isfile(path.join(pictures_dir, f))
62 ]
60 if len(files) == 1:63 if len(files) == 1:
61 one_picture_on_disk = True64 one_picture_on_disk = True
62 break65 break
@@ -66,13 +69,13 @@
66 # check that the camera is able to capture another photo69 # check that the camera is able to capture another photo
67 self.assertThat(exposure_button.enabled, Eventually(Equals(True)))70 self.assertThat(exposure_button.enabled, Eventually(Equals(True)))
6871
69 """Tests clicking on the record control and checks if the flash changes
70 to torch off mode and the recording time appears"""
71 @unittest.skip('Video recording not working for V1.0')72 @unittest.skip('Video recording not working for V1.0')
72 def test_record_video(self):73 def test_record_video(self):
74 """Tests clicking on the record control and checks if the flash changes
75 to torch off mode and the recording time appears.
76
77 """
73 # Get all the elements78 # Get all the elements
74 camera_window = self.main_window.get_camera()
75 toolbar = self.main_window.get_toolbar()
76 record_control = self.main_window.get_record_control()79 record_control = self.main_window.get_record_control()
77 flash_button = self.main_window.get_flash_button()80 flash_button = self.main_window.get_flash_button()
78 stop_watch = self.main_window.get_stop_watch()81 stop_watch = self.main_window.get_stop_watch()
@@ -138,10 +141,12 @@
138 self.assertThat(141 self.assertThat(
139 flash_button.torchMode, Eventually(Equals(torchmode_old_state)))142 flash_button.torchMode, Eventually(Equals(torchmode_old_state)))
140143
141 """Test that the shoot button gets disabled for a while then re-enabled
142 after shooting"""
143 @unittest.skip("Disabled this test due race condition see bug 1227373")144 @unittest.skip("Disabled this test due race condition see bug 1227373")
144 def test_shoot_button_disable(self):145 def test_shoot_button_disable(self):
146 """Test that the shoot button gets disabled for a while then re-enabled
147 after shooting.
148
149 """
145 exposure_button = self.main_window.get_exposure_button()150 exposure_button = self.main_window.get_exposure_button()
146151
147 # The focus ring should be invisible in the beginning152 # The focus ring should be invisible in the beginning
148153
=== modified file 'tests/autopilot/camera_app/tests/test_flash.py'
--- tests/autopilot/camera_app/tests/test_flash.py 2013-11-18 13:34:43 +0000
+++ tests/autopilot/camera_app/tests/test_flash.py 2013-11-22 11:05:37 +0000
@@ -12,25 +12,20 @@
1212
13from camera_app.tests import CameraAppTestCase13from camera_app.tests import CameraAppTestCase
1414
15import time
16import unittest15import unittest
1716
1817
19class TestCameraFlash(CameraAppTestCase):18class TestCameraFlash(CameraAppTestCase):
20 """Tests the flash"""19 """Tests the flash"""
2120
22 """ This is needed to wait for the application to start.
23 In the testfarm, the application may take some time to show up."""
24 def setUp(self):21 def setUp(self):
25 super(TestCameraFlash, self).setUp()22 super(TestCameraFlash, self).setUp()
26 self.assertThat(
27 self.main_window.get_qml_view().visible, Eventually(Equals(True)))
2823
29 def tearDown(self):24 def tearDown(self):
30 super(TestCameraFlash, self).tearDown()25 super(TestCameraFlash, self).tearDown()
3126
32 """Test that flash modes cycle properly"""
33 def test_cycle_flash(self):27 def test_cycle_flash(self):
28 """Test that flash modes cycle properly."""
34 flash_button = self.main_window.get_flash_button()29 flash_button = self.main_window.get_flash_button()
3530
36 #ensure initial state31 #ensure initial state
@@ -51,9 +46,9 @@
51 self.assertThat(flash_button.flashState, Eventually(Equals("off")))46 self.assertThat(flash_button.flashState, Eventually(Equals("off")))
52 self.assertThat(flash_button.torchMode, Equals(False))47 self.assertThat(flash_button.torchMode, Equals(False))
5348
54 """Test that torch modes cycles properly"""
55 @unittest.skip('Video recording not working for V1.0')49 @unittest.skip('Video recording not working for V1.0')
56 def test_cycle_torch(self):50 def test_cycle_torch(self):
51 """Test that torch modes cycles properly."""
57 flash_button = self.main_window.get_flash_button()52 flash_button = self.main_window.get_flash_button()
58 record_button = self.main_window.get_record_control()53 record_button = self.main_window.get_record_control()
59 self.pointing_device.click_object(record_button)54 self.pointing_device.click_object(record_button)
@@ -72,10 +67,12 @@
72 self.assertThat(flash_button.flashState, Eventually(Equals("off")))67 self.assertThat(flash_button.flashState, Eventually(Equals("off")))
73 self.assertThat(flash_button.torchMode, Equals(True))68 self.assertThat(flash_button.torchMode, Equals(True))
7469
75 """When switching between video and picture the previous flash state
76 should be preserved"""
77 @unittest.skip('Video recording not working for V1.0')70 @unittest.skip('Video recording not working for V1.0')
78 def test_remember_state(self):71 def test_remember_state(self):
72 """When switching between video and picture the previous flash state
73 should be preserved.
74
75 """
79 flash_button = self.main_window.get_flash_button()76 flash_button = self.main_window.get_flash_button()
80 record_button = self.main_window.get_record_control()77 record_button = self.main_window.get_record_control()
81 initial_flash_state = flash_button.flashState78 initial_flash_state = flash_button.flashState
@@ -85,7 +82,9 @@
85 self.pointing_device.move_to_object(flash_button)82 self.pointing_device.move_to_object(flash_button)
86 self.pointing_device.click()83 self.pointing_device.click()
87 self.assertThat(84 self.assertThat(
88 flash_button.flashState, Eventually(NotEquals(initial_flash_state)))85 flash_button.flashState,
86 Eventually(NotEquals(initial_flash_state))
87 )
89 second_flash_state = flash_button.flashState88 second_flash_state = flash_button.flashState
90 self.pointing_device.click()89 self.pointing_device.click()
91 self.assertThat(90 self.assertThat(
9291
=== modified file 'tests/autopilot/camera_app/tests/test_focus.py'
--- tests/autopilot/camera_app/tests/test_focus.py 2013-11-18 14:18:52 +0000
+++ tests/autopilot/camera_app/tests/test_focus.py 2013-11-22 11:05:37 +0000
@@ -9,31 +9,28 @@
99
10from autopilot.matchers import Eventually10from autopilot.matchers import Eventually
11from autopilot.platform import model11from autopilot.platform import model
12from testtools.matchers import Equals, NotEquals, GreaterThan12from testtools.matchers import Equals, GreaterThan
13from camera_app.tests import CameraAppTestCase13from camera_app.tests import CameraAppTestCase
1414
15import unittest15import unittest
16import time
1716
1817
19class TestFocus(CameraAppTestCase):18class TestFocus(CameraAppTestCase):
20 """Tests the focus"""19 """Tests the focus"""
2120
22 """ This is needed to wait for the application to start.
23 In the testfarm, the application may take some time to show up."""
24 def setUp(self):21 def setUp(self):
25 super(TestFocus, self).setUp()22 super(TestFocus, self).setUp()
26 self.assertThat(
27 self.main_window.get_qml_view().visible, Eventually(Equals(True)))
2823
29 def tearDown(self):24 def tearDown(self):
30 super(TestFocus, self).tearDown()25 super(TestFocus, self).tearDown()
3126
32 """Test focusing in an area where we know the picture is"""27 @unittest.skipIf(
33 @unittest.skipIf(model() == 'Galaxy Nexus', 'Unusable with Mir enabled on maguro')28 model() == 'Galaxy Nexus',
29 'Unusable with Mir enabled on maguro'
30 )
34 def test_focus_valid_and_disappear(self):31 def test_focus_valid_and_disappear(self):
32 """Test focusing in an area where we know the picture is."""
35 focus_ring = self.main_window.get_focus_ring()33 focus_ring = self.main_window.get_focus_ring()
36 toolbar = self.main_window.get_toolbar()
37 feed = self.main_window.get_viewfinder_geometry()34 feed = self.main_window.get_viewfinder_geometry()
38 switch_cameras = self.main_window.get_swap_camera_button()35 switch_cameras = self.main_window.get_swap_camera_button()
39 exposure_button = self.main_window.get_exposure_button()36 exposure_button = self.main_window.get_exposure_button()
@@ -60,7 +57,10 @@
60 self.assertThat(exposure_button.enabled, Eventually(Equals(True)))57 self.assertThat(exposure_button.enabled, Eventually(Equals(True)))
6158
62 # Click in the center of the viewfinder area59 # Click in the center of the viewfinder area
63 click_coords =[feed.globalRect[2] // 2 + feed.globalRect[0], feed.globalRect[3] // 2 + feed.globalRect[1]]60 click_coords = [
61 feed.globalRect[2] // 2 + feed.globalRect[0],
62 feed.globalRect[3] // 2 + feed.globalRect[1]
63 ]
64 self.pointing_device.move(click_coords[0], click_coords[1])64 self.pointing_device.move(click_coords[0], click_coords[1])
65 self.pointing_device.click()65 self.pointing_device.click()
6666
@@ -73,10 +73,15 @@
73 # After some seconds the focus ring should fade out73 # After some seconds the focus ring should fade out
74 self.assertThat(focus_ring.opacity, Eventually(Equals(0.0)))74 self.assertThat(focus_ring.opacity, Eventually(Equals(0.0)))
7575
76 @unittest.skipIf(model() == 'Galaxy Nexus', 'Unusable with Mir enabled on maguro')76 @unittest.skipIf(
77 model() == 'Galaxy Nexus',
78 'Unusable with Mir enabled on maguro'
79 )
77 def test_focus_invalid(self):80 def test_focus_invalid(self):
78 """Tests clicking outside of the viewfinder image area, where it should81 """Tests clicking outside of the viewfinder image area, where it should
79 not focus."""82 not focus.
83
84 """
80 toolbar = self.main_window.get_toolbar()85 toolbar = self.main_window.get_toolbar()
81 zoom = self.main_window.get_zoom_control()86 zoom = self.main_window.get_zoom_control()
82 feed = self.main_window.get_viewfinder_geometry()87 feed = self.main_window.get_viewfinder_geometry()
@@ -98,8 +103,8 @@
98103
99 # Check if there's a gap between the viewfinder feed and the zoom104 # Check if there's a gap between the viewfinder feed and the zoom
100 # control. If there is, test that focusing there won't show the focus105 # control. If there is, test that focusing there won't show the focus
101 #ring.106 # ring.
102 if zoom.y > feed.height: # Feed is aligned to the top of the window107 if zoom.y > feed.height: # Feed is aligned to the top of the window
103 x, y, h, w = zoom.globalRect108 x, y, h, w = zoom.globalRect
104 click_coords = [x + (h / 2), y - 2]109 click_coords = [x + (h / 2), y - 2]
105 self.pointing_device.move(click_coords[0], click_coords[1])110 self.pointing_device.move(click_coords[0], click_coords[1])
@@ -119,9 +124,12 @@
119 self.pointing_device.click()124 self.pointing_device.click()
120 self.assertThat(focus_ring.opacity, Eventually(Equals(0.0)))125 self.assertThat(focus_ring.opacity, Eventually(Equals(0.0)))
121126
122 """Tests dragging the focus ring"""127 @unittest.skipIf(
123 @unittest.skipIf(model() == 'Galaxy Nexus', 'Unusable with Mir enabled on maguro')128 model() == 'Galaxy Nexus',
129 'Unusable with Mir enabled on maguro'
130 )
124 def test_move_focus_ring(self):131 def test_move_focus_ring(self):
132 """Tests dragging the focus ring."""
125 focus_ring = self.main_window.get_focus_ring()133 focus_ring = self.main_window.get_focus_ring()
126 feed = self.main_window.get_viewfinder_geometry()134 feed = self.main_window.get_viewfinder_geometry()
127 switch_cameras = self.main_window.get_swap_camera_button()135 switch_cameras = self.main_window.get_swap_camera_button()
128136
=== modified file 'tests/autopilot/camera_app/tests/test_zoom.py'
--- tests/autopilot/camera_app/tests/test_zoom.py 2013-11-18 13:34:43 +0000
+++ tests/autopilot/camera_app/tests/test_zoom.py 2013-11-22 11:05:37 +0000
@@ -12,25 +12,20 @@
1212
13from camera_app.tests import CameraAppTestCase13from camera_app.tests import CameraAppTestCase
1414
15import time
16import unittest15import unittest
1716
1817
19class TestCameraZoom(CameraAppTestCase):18class TestCameraZoom(CameraAppTestCase):
20 """Tests the main camera features"""19 """ Tests the main camera features. """
2120
22 """ This is needed to wait for the application to start.
23 In the testfarm, the application may take some time to show up."""
24 def setUp(self):21 def setUp(self):
25 super(TestCameraZoom, self).setUp()22 super(TestCameraZoom, self).setUp()
26 self.assertThat(
27 self.main_window.get_qml_view().visible, Eventually(Equals(True)))
2823
29 def tearDown(self):24 def tearDown(self):
30 super(TestCameraZoom, self).tearDown()25 super(TestCameraZoom, self).tearDown()
3126
32 """Tests the zoom slider"""
33 def test_slider(self):27 def test_slider(self):
28 """Tests the zoom slider."""
34 zoom_control = self.main_window.get_zoom_control()29 zoom_control = self.main_window.get_zoom_control()
35 zoom_button = self.main_window.get_zoom_slider_button()30 zoom_button = self.main_window.get_zoom_slider_button()
3631
@@ -106,7 +101,9 @@
106 self.pointing_device.move_to_object(minus)101 self.pointing_device.move_to_object(minus)
107 self.pointing_device.click()102 self.pointing_device.click()
108 self.assertThat(103 self.assertThat(
109 zoom_control.value, Eventually(NotEquals(zoom_control.maximumValue)))104 zoom_control.value,
105 Eventually(NotEquals(zoom_control.maximumValue))
106 )
110107
111 value_before_plus = zoom_control.value108 value_before_plus = zoom_control.value
112109
@@ -115,7 +112,8 @@
115 self.assertThat(112 self.assertThat(
116 zoom_control.value, Eventually(GreaterThan(value_before_plus)))113 zoom_control.value, Eventually(GreaterThan(value_before_plus)))
117114
118 # Test that keeping the minus button pressed eventually reaches min zoom115 # Test that keeping the minus button pressed eventually reaches
116 # min zoom.
119 self.pointing_device.move_to_object(minus)117 self.pointing_device.move_to_object(minus)
120 self.pointing_device.press()118 self.pointing_device.press()
121 self.assertThat(zoom_control.value, Eventually(Equals(1.0)))119 self.assertThat(zoom_control.value, Eventually(Equals(1.0)))

Subscribers

People subscribed via source and target branches