Code review comment for lp:~om26er/camera-app/ap_tests_improvements

Revision history for this message
Ugo Riboni (uriboni) wrote :

291 + """Tests clicking outside of the viewfinder image area, where it should
292 + not focus
293 +
294 + """

Why all the extra space ?

346 + center_click_coords = list(self.pointing_device.position())
347 +
348 + focus_ring_center = self.get_center(focus_ring)
349 +

Same issue here

356 + drag_end_coords = [focus_ring_center[0] / 2, focus_ring_center[1] / 2]
357 + self.pointing_device.drag(
358 + focus_ring_center[0], focus_ring_center[1], drag_end_coords[0], drag_end_coords[1])
359

Since you're improving readability by adding intermediate variable in other places, you might want to do this here for the parameters to drag() too.

« Back to merge proposal