Code review comment for lp:~olivier-mattelaer/mg5amcnlo/new_drawing_option

Revision history for this message
Johan Alwall (johan-alwall) wrote :

Hi Olivier,

Now things look really nice! I actually especially like max_size=1.5, external=0. Only one, very minor detail (in case you are not too tired yet): The particle labels tend to overlap, e.g. (with the same process as before) diagram 9, the e+e- are written on top of each other. I think this can be fixed just by changing the distance from the line to the text, or alternatively by always writing the label below-right of the line. If you have time, you can play around a bit with this. I have to say, the diagrams now are already quite at a par with those from MG4.

Just a question about the non-propagating contraction: Now, you're not checking for identical diagrams and combining those, right? At least I don't get them combined.

Thanks a lot,
Johan

« Back to merge proposal